third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2082503003: ASSERT -> DCHECK conversions in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/EditingState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index 3224f4871fae71780c213fc7616c0a67351dd933..46ac6b3b09a6f90b862660434f9a4b1e0aa79c89 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -189,7 +189,7 @@ bool CompositeEditCommand::apply()

case EditActionUnspecified:

break;

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return false;

}

@@ -581,7 +581,7 @@ Position CompositeEditCommand::positionOutsideTabSpan(const Position& pos)

switch (pos.anchorType()) {

case PositionAnchorType::BeforeChildren:

case PositionAnchorType::AfterChildren:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return pos;

case PositionAnchorType::OffsetInAnchor:

break;