Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 1d6180e5c7245b1bb0c41492d311a67e57d00ba7..5c5f415d3187d909368a021d2ec52ab3580b5816 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -191,7 +191,7 @@ static bool applyCommandToFrame(LocalFrame& frame, EditorCommandSource source, E
frame.editor().applyStyle(style);
return true;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -266,7 +266,7 @@ static bool executeApplyParagraphStyle(LocalFrame& frame, EditorCommandSource so
frame.editor().applyParagraphStyle(style);
return true;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -439,7 +439,7 @@ static bool executeDelete(LocalFrame& frame, Event*, EditorCommandSource source,
TypingCommand::deleteKeyPressed(*frame.document(), frame.selection().granularity() == WordGranularity ? TypingCommand::SmartDelete : 0);
return true;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -578,7 +578,7 @@ static bool executeForwardDelete(LocalFrame& frame, Event*, EditorCommandSource
return false;
return true;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -635,7 +635,7 @@ static bool executeInsertLineBreak(LocalFrame& frame, Event* event, EditorComman
DCHECK(frame.document());
return TypingCommand::insertLineBreak(*frame.document());
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -1358,7 +1358,7 @@ static bool enabledDelete(LocalFrame& frame, Event* event, EditorCommandSource s
// otherwise removes a character
return enabledInEditableText(frame, event, source);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -1517,7 +1517,7 @@ static String valueDefaultParagraphSeparator(LocalFrame& frame, Event*)
return pTag.localName();
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return String();
}
@@ -1826,7 +1826,7 @@ bool Editor::Command::isSupported() const
case CommandFromDOM:
return m_command->isSupportedFromDOM(m_frame.get());
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698