third_party/WebKit/Source/core/editing/commands/EditingState.h - Issue 2082503003: ASSERT -> DCHECK conversions in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditingState.h

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditingState.h

diff --git a/third_party/WebKit/Source/core/editing/commands/EditingState.h b/third_party/WebKit/Source/core/editing/commands/EditingState.h

index ab20a8784c2cdd9f40ffce75cd5be23e32771903..64c59279da93206ee3ee011998d82a063cace04b 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditingState.h

+++ b/third_party/WebKit/Source/core/editing/commands/EditingState.h

@@ -61,7 +61,7 @@ private:

} \

} while (false)

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

// This class is inspired by |NoExceptionStateAssertionChecker|.

class NoEditingAbortChecker final {

STACK_ALLOCATED();

@@ -81,7 +81,7 @@ private:

// If a function with EditingState* argument should not be aborted,

// ASSERT_NO_EDITING_ABORT should be specified.

// fooFunc(...., ASSERT_NO_EDITING_ABORT);

-// It causes an assertion failure If ENABLE(ASSERT) and the function was aborted

+// It causes an assertion failure If DCHECK_IS_ON() and the function was aborted

// unexpectedly.

#define ASSERT_NO_EDITING_ABORT (NoEditingAbortChecker(__FILE__, __LINE__).editingState())

#else