Remove calls to deprecated MessageLoop methods in content.

Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8
Cr-Commit-Position: refs/heads/master@{#403787}

[fdoray, 2016-06-22 13:56:38]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2016-06-22 15:37:40]

Can you review this CL? Thanks.

[jam, 2016-06-22 19:37:06]

jam@chromium.org changed reviewers:
+ nick@chromium.org
- jam@chromium.org

[jam, 2016-06-22 19:37:07]

Redirecting to Nick to load balance

[ncarter (slow), 2016-06-22 20:51:09]

Only got about halfway through, but I found myself asking the same question in a
lot of places, so I'm just going to go ahead and publish comments now.

https://codereview.chromium.org/2082343002/diff/1/content/browser/browser_thr...
File content/browser/browser_thread_unittest.cc (right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/browser_thr...
content/browser/browser_thread_unittest.cc:116:
base::Bind(&base::MessageLoop::QuitWhenIdle,
Shouldn't this use a QuitWhenIdleClosure from the runloop?

https://codereview.chromium.org/2082343002/diff/1/content/browser/devtools/de...
File content/browser/devtools/devtools_manager_unittest.cc (right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/devtools/de...
content/browser/devtools/devtools_manager_unittest.cc:151: FROM_HERE,
base::MessageLoop::QuitWhenIdleClosure(),
Should this use the QuitWhenIdleClosure from the RunLoop?

https://codereview.chromium.org/2082343002/diff/1/content/browser/devtools/de...
content/browser/devtools/devtools_manager_unittest.cc:163: FROM_HERE,
base::MessageLoop::QuitWhenIdleClosure(),
Should this use the QuitWhenIdleClosure from the RunLoop?

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
(right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc:105:
message_loop_.RunUntilIdle();
Should this be converted to base::RunLoop().RunUntilIdle()?

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_widget_host_view_guest_unittest.cc
(right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_widget_host_view_guest_unittest.cc:78:
message_loop_.RunUntilIdle();
Same question here.

https://codereview.chromium.org/2082343002/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_unittest.cc (right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_unittest.cc:1567:
base::MessageLoop::current(), &base::MessageLoop::QuitWhenIdle);
It seems inconsistent to update the Run() semantics here, without updating this
usage too (I'm assuming this should be made to use the converted to the
RunLoop's QuitWhenIdle).

What's the plan for this?

https://codereview.chromium.org/2082343002/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_unittest.cc:2019:
base::MessageLoop::current(), &base::MessageLoop::QuitWhenIdle);
Ditto

[fdoray, 2016-06-28 20:40:34]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org

[fdoray, 2016-06-28 20:40:35]

jochen@: Can you review this CL? Thanks. (ncarter is OOO)

https://codereview.chromium.org/2082343002/diff/1/content/browser/browser_thr...
File content/browser/browser_thread_unittest.cc (right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/browser_thr...
content/browser/browser_thread_unittest.cc:116:
base::Bind(&base::MessageLoop::QuitWhenIdle,
On 2016/06/22 20:51:08, ncarter wrote:
> Shouldn't this use a QuitWhenIdleClosure from the runloop?

Yes, but it's not trivial to automate this change.

The plan is:
1. Migrate MessageLoop::Run/RunUntilIdle -> RunLoop::Run/RunUntilIdle.
2. Delete MessageLoop::Run/RunUntilIdle.
3. People are now forced to use RunLoop to run a MessageLoop. Hopefully, they
will start using RunLoop::Quit/QuitWhenIdle instead of
MessageLoop::QuitNow/QuitWhenIdle.
4. Write scripts to migrate call from
MessageLoop::QuitNow/QuitWhenIdle/QuitWhenIdleClosure and migrate them to
RunLoop. We hope that because of step 3, a limited number of new calls to
deprecated methods will be introduced during that time.

tl;dr: We want to delete MessageLoop::Run/RunUntilIdle so that people start
using RunLoop. We also want to delete MessageLoop::Quit/QuitWhenIdle, but it's
harder to automate so it will be done in a separate phase.

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
(right):

https://codereview.chromium.org/2082343002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc:105:
message_loop_.RunUntilIdle();
On 2016/06/22 20:51:09, ncarter (gone til 6-jul) wrote:
> Should this be converted to base::RunLoop().RunUntilIdle()?

Done.

[jochen (gone - plz use gerrit), 2016-06-29 15:27:54]

sorry for the delay, will review later or tomorrow

[DMGordon79, 2016-07-01 06:49:21]

dmgordon79@gmail.com changed reviewers:
+ DMGordon79@gmail.com

[DMGordon79, 2016-07-01 06:49:27]

lgtm

[fdoray, 2016-07-01 14:15:12]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:15:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 14:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:22:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2016-07-04 13:59:00]

fdoray@chromium.org changed reviewers:
+ dmgordon79@gmail.com
- DMGordon79@gmail.com

[fdoray, 2016-07-04 13:59:01]

jochen@: ping

[jochen (gone - plz use gerrit), 2016-07-05 14:24:43]

lgtm

[fdoray, 2016-07-05 14:28:52]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-07-05 14:29:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 16:06:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-05 16:06:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-05 16:08:12]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove calls to deprecated MessageLoop methods in content.

This CL makes the following replacements in
content:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8
Cr-Commit-Position: refs/heads/master@{#403787}
==========

[commit-bot: I haz the power, 2016-07-05 16:08:14]

Patchset 2 (id:??) landed as
https://crrev.com/e716a9021e055fc77e0459d1a46b269864333cf8
Cr-Commit-Position: refs/heads/master@{#403787}