content/browser/devtools/protocol/devtools_protocol_browsertest.cc - Issue 2082343002: Remove calls to deprecated MessageLoop methods in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2082343002: Remove calls to deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_manager_unittest.cc ('k') | content/browser/devtools/site_per_process_devtools_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

index 1a7e764be6542aaaa5ca93444eba4774086d5739..ec22f213f3f851a430a2388391c40a47352e14ed 100644

--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

@@ -9,6 +9,7 @@

#include "base/command_line.h"

#include "base/json/json_reader.h"

#include "base/json/json_writer.h"

+#include "base/run_loop.h"

#include "base/values.h"

#include "build/build_config.h"

#include "content/public/browser/devtools_agent_host.h"

@@ -127,7 +128,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,

// Only run loop if we are not finished yet.

if (in_dispatch_ && wait) {

waiting_for_command_result_id_ = last_sent_id_;

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

}

in_dispatch_ = false;

}