content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc - Issue 2082343002: Remove calls to deprecated MessageLoop methods in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

Issue 2082343002: Remove calls to deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc ('k') | content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

index fc604b39f4603303ff0130a8b8e88ea3337357ae..7174fb1ac50a42da92d1df01674a14c785224737 100644

--- a/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

+++ b/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc

@@ -10,6 +10,7 @@

#include <deque>

#include "base/macros.h"

+#include "base/run_loop.h"

#include "base/sys_byteorder.h"

#include "content/browser/renderer_host/p2p/socket_host_test_utils.h"

#include "net/socket/stream_socket.h"

@@ -237,7 +238,7 @@ TEST_F(P2PSocketHostTcpTest, AsyncWrites) {

CreateStunResponse(&packet2);

socket_host_->Send(dest_.ip_address, packet2, options, 0);

- message_loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

std::string expected_data;

expected_data.append(IntToSize(packet1.size()));

@@ -392,7 +393,7 @@ TEST_F(P2PSocketHostStunTcpTest, AsyncWrites) {

CreateStunResponse(&packet2);

socket_host_->Send(dest_.ip_address, packet2, options, 0);

- message_loop.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

std::string expected_data;

expected_data.append(packet1.begin(), packet1.end());