Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2082333002: Remove calls to deprecated MessageLoop methods in components. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, wfh+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, tfarina, tracing+reviews_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jochen+watch_chromium.org, noyau+watch_chromium.org, pfeldman, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, scheduler-bugs_chromium.org, wifiprefetch-reviews_google.com, sync-reviews_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in components. This CL makes the following replacements in components: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=caitkp@chromium.org Committed: https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80 Cr-Commit-Position: refs/heads/master@{#401396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -240 lines) Patch
M components/autofill/core/browser/autofill_download_manager_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 92 chunks +93 lines, -92 lines 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 16 chunks +17 lines, -16 lines 0 comments Download
M components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/history/core/browser/history_querying_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/history/core/browser/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_service_unittest.cc View 13 chunks +13 lines, -12 lines 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/invalidation/impl/invalidation_notifier_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/invalidation/impl/non_blocking_invalidator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/sync_invalidation_listener_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/invalidation/impl/sync_system_resources_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter_unittest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/network_time/network_time_tracker.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/omnibox/browser/autocomplete_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/omnibox/browser/history_quick_provider_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/omnibox/browser/history_url_provider_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M components/omnibox/browser/shortcuts_backend_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/omnibox/browser/shortcuts_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/async_policy_provider_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/precache/core/fetcher_pool_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc View 12 chunks +14 lines, -13 lines 0 comments Download
M components/scheduler/base/task_queue_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/sync_driver/glue/browser_thread_model_worker_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M components/sync_driver/glue/sync_backend_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/glue/sync_backend_registrar_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/glue/ui_model_worker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/test_runner/mock_screen_orientation_client.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M components/tracing/child/child_trace_message_filter_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/wallpaper/wallpaper_resizer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/wifi/wifi_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:41:08 UTC) #1
Cait (Slow)
lgtm
4 years, 6 months ago (2016-06-22 20:36:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082333002/1
4 years, 6 months ago (2016-06-22 20:43:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 20:56:01 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:58:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c85099dabdd4ae0fe75c01f44b11278229dd3f80
Cr-Commit-Position: refs/heads/master@{#401396}

Powered by Google App Engine
This is Rietveld 408576698