components/signin/core/browser/gaia_cookie_manager_service_unittest.cc - Issue 2082333002: Remove calls to deprecated MessageLoop methods in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

Issue 2082333002: Remove calls to deprecated MessageLoop methods in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc ('k') | components/ssl_config/ssl_config_service_manager_pref_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

diff --git a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

index 33e67e4d7a1d900e89cb27902c9afa887a87319f..9e5f896f95662bf7c5103f22c16460484c01aab7 100644

--- a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

+++ b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

@@ -13,6 +13,7 @@

#include "base/macros.h"

#include "base/memory/ref_counted.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/stringprintf.h"

#include "base/test/histogram_tester.h"

@@ -226,7 +227,7 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetried) {

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(1100));

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

SimulateMergeSessionSuccess(&helper, "token");

DCHECK(!helper.is_running());

}

@@ -250,7 +251,7 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetriedTwice) {

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(1100));

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

SimulateMergeSessionFailure(&helper, canceled());

DCHECK(helper.is_running());

// Next transient error incurs a retry after 3 seconds.

@@ -259,7 +260,7 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetriedTwice) {

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(3100));

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

SimulateMergeSessionSuccess(&helper, "token");

DCHECK(!helper.is_running());

histograms.ExpectUniqueSample("OAuth2Login.MergeSessionRetry",