components/omnibox/browser/shortcuts_provider_unittest.cc - Issue 2082333002: Remove calls to deprecated MessageLoop methods in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/shortcuts_provider_unittest.cc

Issue 2082333002: Remove calls to deprecated MessageLoop methods in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/shortcuts_backend_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/shortcuts_provider_unittest.cc

diff --git a/components/omnibox/browser/shortcuts_provider_unittest.cc b/components/omnibox/browser/shortcuts_provider_unittest.cc

index 3c11e208d3f78503895621c9b54ff7ce3a85012a..368aaa024ac8d244c7b23dd7193dbbb571762647 100644

--- a/components/omnibox/browser/shortcuts_provider_unittest.cc

+++ b/components/omnibox/browser/shortcuts_provider_unittest.cc

@@ -18,6 +18,7 @@

#include "base/memory/ptr_util.h"

#include "base/memory/ref_counted.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "base/test/sequenced_worker_pool_owner.h"

@@ -287,7 +288,7 @@ void ShortcutsProviderTest::SetUp() {

void ShortcutsProviderTest::TearDown() {

// Run all pending tasks or else some threads hold on to the message loop

// and prevent it from being deleted.

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

provider_ = NULL;

}