components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc - Issue 2082333002: Remove calls to deprecated MessageLoop methods in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

Issue 2082333002: Remove calls to deprecated MessageLoop methods in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/base/task_queue_manager_unittest.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

diff --git a/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc b/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

index 103f50d513b1a9119482596c5257fe5f9b371a43..1d29f244f2f98b024a1848927e0e8ae87136f314 100644

--- a/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

+++ b/components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc

@@ -83,7 +83,7 @@ TEST_F(WebThreadImplForRendererSchedulerTest, TestTaskObserver) {

thread_->getWebTaskRunner()->postTask(blink::WebTraceLocation(),

task.release());

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

thread_->removeTaskObserver(&observer);

}

@@ -102,7 +102,7 @@ TEST_F(WebThreadImplForRendererSchedulerTest, TestWorkBatchWithOneTask) {

thread_->getWebTaskRunner()->postTask(blink::WebTraceLocation(),

task.release());

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

thread_->removeTaskObserver(&observer);

}

@@ -128,7 +128,7 @@ TEST_F(WebThreadImplForRendererSchedulerTest, TestWorkBatchWithTwoTasks) {

task1.release());

thread_->getWebTaskRunner()->postTask(blink::WebTraceLocation(),

task2.release());

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

thread_->removeTaskObserver(&observer);

}

@@ -161,7 +161,7 @@ TEST_F(WebThreadImplForRendererSchedulerTest, TestWorkBatchWithThreeTasks) {

task2.release());

thread_->getWebTaskRunner()->postTask(blink::WebTraceLocation(),

task3.release());

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

thread_->removeTaskObserver(&observer);

}

@@ -206,7 +206,7 @@ TEST_F(WebThreadImplForRendererSchedulerTest, TestNestedRunLoop) {

message_loop_.task_runner()->PostTask(

FROM_HERE, base::Bind(&EnterRunLoop, base::Unretained(&message_loop_),

base::Unretained(thread_.get())));

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

thread_->removeTaskObserver(&observer);

}