components/tracing/child/child_trace_message_filter_unittest.cc - Issue 2082333002: Remove calls to deprecated MessageLoop methods in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child/child_trace_message_filter_unittest.cc

Issue 2082333002: Remove calls to deprecated MessageLoop methods in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_screen_orientation_client.cc ('k') | components/wallpaper/wallpaper_resizer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/child/child_trace_message_filter_unittest.cc

diff --git a/components/tracing/child/child_trace_message_filter_unittest.cc b/components/tracing/child/child_trace_message_filter_unittest.cc

index e2bd3d810bfe4668e877e231d7658ffcfb75611c..8a7ccec7e4e91194e2ee85998658b45ed739a6a3 100644

--- a/components/tracing/child/child_trace_message_filter_unittest.cc

+++ b/components/tracing/child/child_trace_message_filter_unittest.cc

@@ -8,6 +8,7 @@

#include "base/memory/ref_counted.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "components/tracing/common/tracing_messages.h"

#include "ipc/ipc_message.h"

#include "ipc/ipc_sender.h"

@@ -56,7 +57,7 @@ TEST_F(ChildTraceMessageFilterTest, TestHistogramDoesNotTrigger) {

OnSetUMACallback("foo1", 20000, 25000, true);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_FALSE(fake_sender_.last_message_);

}

@@ -66,7 +67,7 @@ TEST_F(ChildTraceMessageFilterTest, TestHistogramTriggers) {

OnSetUMACallback("foo2", 1, 3, true);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_TRUE(fake_sender_.last_message_);

EXPECT_EQ(fake_sender_.last_message_->type(),

@@ -78,7 +79,7 @@ TEST_F(ChildTraceMessageFilterTest, TestHistogramAborts) {

OnSetUMACallback("foo3", 1, 3, false);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_TRUE(fake_sender_.last_message_);

EXPECT_EQ(fake_sender_.last_message_->type(),

« no previous file with comments | « components/test_runner/mock_screen_orientation_client.cc ('k') | components/wallpaper/wallpaper_resizer_unittest.cc » ('j') | no next file with comments »