Rename PermissionBubbleManager to PermissionRequestManager

Rename PermissionBubbleManager to PermissionRequestManager

Additionally moves the PermissionRequestManager files from
chrome/browser/ui/ to chrome/browser/permissions.

This is a step towards being able to share generic permission request
handling code between Bubbles on desktop and infobars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1686903002/ by mlamouri@chromium.org

BUG=606138
Committed: https://crrev.com/a771c23ebb5c32480a32f41ad419a97ac3251b8e
Cr-Commit-Position: refs/heads/master@{#405029}

[tsergeant, 2016-07-07 03:56:04]

Patchset #3 (id:40001) has been deleted

[tsergeant, 2016-07-07 06:48:17]

Patchset #3 (id:60001) has been deleted

[tsergeant, 2016-07-07 23:26:14]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 23:27:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 01:03:19]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-07-08 01:15:51]

tsergeant@chromium.org changed reviewers:
+ felt@chromium.org

[tsergeant, 2016-07-08 01:15:53]

Hi Adrienne, can you please take a look?

This is an updated version of a patch you've already reviewed (see description
for details)

[felt, 2016-07-11 18:45:23]

👍👍👍 lgtm

[tsergeant, 2016-07-13 00:47:37]

tsergeant@chromium.org changed reviewers:
+ thestig@chromium.org

[tsergeant, 2016-07-13 00:47:38]

+thestig@, can you please review the remainder of the CL?

Everything outside of c/b/permissions and c/b/ui/website_settings (which
Adrienne has already owners-reviewed) is just a straight find-and-replace.

[Lei Zhang, 2016-07-13 01:53:14]

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:1919: ['exclude',
'^browser/ui/website_settings/mock_permission_bubble_request\\.(cc|h)$'],
Is there a "non-ios" list to put the files in instead? If iOS magically switches
to GN tomorrow, they aren't going to get this for free.

[Lei Zhang, 2016-07-13 02:04:24]

https://codereview.chromium.org/2081103002/diff/120001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
(right):

https://codereview.chromium.org/2081103002/diff/120001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_bubble_factory.h:21: //
chrome/browser/ui/website_settings/permission_request_manager_unittest.cc
Ah ha! A mistake! I finally feel useful.

chrome/browser/permissions/permission_request_manager_unittest.cc

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:1919: ['exclude',
'^browser/ui/website_settings/mock_permission_bubble_request\\.(cc|h)$'],
Actually, is this even needed? Doesn't line 1917 start off excluding everything?

[tsergeant, 2016-07-13 04:20:53]

https://codereview.chromium.org/2081103002/diff/120001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_bubble_factory.h
(right):

https://codereview.chromium.org/2081103002/diff/120001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_bubble_factory.h:21: //
chrome/browser/ui/website_settings/permission_request_manager_unittest.cc
On 2016/07/13 02:04:24, Lei Zhang wrote:
> Ah ha! A mistake! I finally feel useful.
> 
> chrome/browser/permissions/permission_request_manager_unittest.cc

Ah, nice pickup. Done.

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/2081103002/diff/120001/chrome/chrome_tests_un...
chrome/chrome_tests_unit.gypi:1919: ['exclude',
'^browser/ui/website_settings/mock_permission_bubble_request\\.(cc|h)$'],
On 2016/07/13 02:04:24, Lei Zhang wrote:
> Actually, is this even needed? Doesn't line 1917 start off excluding
everything?

Hmm, I think you're right.

The iOS trybots seem fine without it.

[Lei Zhang, 2016-07-13 04:21:34]

lgtm

[tsergeant, 2016-07-13 04:24:20]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-07-13 04:24:20]

The patchset sent to the CQ was uploaded after l-g-t-m from felt@chromium.org
Link to the patchset: https://codereview.chromium.org/2081103002/#ps140001
(title: "Review comments")

[commit-bot: I haz the power, 2016-07-13 04:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 04:55:16]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-07-13 04:55:30]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 04:57:17]

Description was changed from

==========
Rename PermissionBubbleManager to PermissionRequestManager

Additionally moves the PermissionRequestManager files from
chrome/browser/ui/ to chrome/browser/permissions.

This is a step towards being able to share generic permission request
handling code between Bubbles on desktop and infobars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1686903002/ by mlamouri@chromium.org

BUG=606138
==========

to

==========
Rename PermissionBubbleManager to PermissionRequestManager

Additionally moves the PermissionRequestManager files from
chrome/browser/ui/ to chrome/browser/permissions.

This is a step towards being able to share generic permission request
handling code between Bubbles on desktop and infobars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1686903002/ by mlamouri@chromium.org

BUG=606138

Committed: https://crrev.com/a771c23ebb5c32480a32f41ad419a97ac3251b8e
Cr-Commit-Position: refs/heads/master@{#405029}
==========

[commit-bot: I haz the power, 2016-07-13 04:57:19]

Patchset 6 (id:??) landed as
https://crrev.com/a771c23ebb5c32480a32f41ad419a97ac3251b8e
Cr-Commit-Position: refs/heads/master@{#405029}