Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: chrome/browser/media/webrtc_browsertest_base.cc

Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_browsertest_base.cc
diff --git a/chrome/browser/media/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc_browsertest_base.cc
index 9a40c5b80c4497e6362c276edf227dd8e715f7b8..2213da9f1c64c33f069546e4b51c8d60692b5003 100644
--- a/chrome/browser/media/webrtc_browsertest_base.cc
+++ b/chrome/browser/media/webrtc_browsertest_base.cc
@@ -12,10 +12,10 @@
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "chrome/browser/media/webrtc_browsertest_common.h"
+#include "chrome/browser/permissions/permission_request_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
@@ -87,17 +87,18 @@ bool JavascriptErrorDetectingLogHandler(int severity,
// PermissionRequestObserver ---------------------------------------------------
// Used to observe the creation of permission prompt without responding.
-class PermissionRequestObserver : public PermissionBubbleManager::Observer {
+class PermissionRequestObserver : public PermissionRequestManager::Observer {
public:
explicit PermissionRequestObserver(content::WebContents* web_contents)
- : bubble_manager_(PermissionBubbleManager::FromWebContents(web_contents)),
+ : request_manager_(
+ PermissionRequestManager::FromWebContents(web_contents)),
request_shown_(false),
message_loop_runner_(new content::MessageLoopRunner) {
- bubble_manager_->AddObserver(this);
+ request_manager_->AddObserver(this);
}
~PermissionRequestObserver() override {
// Safe to remove twice if it happens.
- bubble_manager_->RemoveObserver(this);
+ request_manager_->RemoveObserver(this);
}
void Wait() { message_loop_runner_->Run(); }
@@ -105,14 +106,14 @@ class PermissionRequestObserver : public PermissionBubbleManager::Observer {
bool request_shown() const { return request_shown_; }
private:
- // PermissionBubbleManager::Observer
+ // PermissionRequestManager::Observer
void OnBubbleAdded() override {
request_shown_ = true;
- bubble_manager_->RemoveObserver(this);
+ request_manager_->RemoveObserver(this);
message_loop_runner_->Quit();
}
- PermissionBubbleManager* bubble_manager_;
+ PermissionRequestManager* request_manager_;
bool request_shown_;
scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
@@ -148,8 +149,8 @@ bool WebRtcTestBase::GetUserMediaWithSpecificConstraintsAndAccept(
content::WebContents* tab_contents,
const std::string& constraints) const {
std::string result;
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::ACCEPT_ALL);
PermissionRequestObserver permissionRequestObserver(tab_contents);
GetUserMedia(tab_contents, constraints);
EXPECT_TRUE(permissionRequestObserver.request_shown());
@@ -162,8 +163,8 @@ bool WebRtcTestBase::GetUserMediaWithSpecificConstraintsAndAcceptIfPrompted(
content::WebContents* tab_contents,
const std::string& constraints) const {
std::string result;
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::ACCEPT_ALL);
GetUserMedia(tab_contents, constraints);
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
tab_contents->GetMainFrame(), "obtainGetUserMediaResult();", &result));
@@ -179,8 +180,8 @@ void WebRtcTestBase::GetUserMediaWithSpecificConstraintsAndDeny(
content::WebContents* tab_contents,
const std::string& constraints) const {
std::string result;
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::DENY_ALL);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::DENY_ALL);
PermissionRequestObserver permissionRequestObserver(tab_contents);
GetUserMedia(tab_contents, constraints);
EXPECT_TRUE(permissionRequestObserver.request_shown());
@@ -192,8 +193,8 @@ void WebRtcTestBase::GetUserMediaWithSpecificConstraintsAndDeny(
void WebRtcTestBase::GetUserMediaAndDismiss(
content::WebContents* tab_contents) const {
std::string result;
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::DISMISS);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::DISMISS);
PermissionRequestObserver permissionRequestObserver(tab_contents);
GetUserMedia(tab_contents, kAudioVideoCallConstraints);
EXPECT_TRUE(permissionRequestObserver.request_shown());
@@ -214,8 +215,8 @@ void WebRtcTestBase::GetUserMediaAndExpectAutoAcceptWithoutPrompt(
// we set an auto-response to avoid leaving the prompt hanging. The choice of
// DENY_ALL makes sure that the response to the prompt doesn't accidentally
// result in a newly granted media stream permission.
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::DENY_ALL);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::DENY_ALL);
PermissionRequestObserver permissionRequestObserver(tab_contents);
GetUserMedia(tab_contents, kAudioVideoCallConstraints);
EXPECT_FALSE(permissionRequestObserver.request_shown());
@@ -235,8 +236,8 @@ void WebRtcTestBase::GetUserMediaAndExpectAutoDenyWithoutPrompt(
// we set an auto-response to avoid leaving the prompt hanging. The choice of
// ACCEPT_ALL makes sure that the response to the prompt doesn't accidentally
// result in a newly granted media stream permission.
- PermissionBubbleManager::FromWebContents(tab_contents)
- ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
+ PermissionRequestManager::FromWebContents(tab_contents)
+ ->set_auto_response_for_test(PermissionRequestManager::ACCEPT_ALL);
PermissionRequestObserver permissionRequestObserver(tab_contents);
GetUserMedia(tab_contents, kAudioVideoCallConstraints);
EXPECT_FALSE(permissionRequestObserver.request_shown());
@@ -271,8 +272,8 @@ WebRtcTestBase::OpenPageAndGetUserMediaInNewTabWithConstraints(
browser()->tab_strip_model()->GetActiveWebContents();
// Accept if necessary, but don't expect a prompt (because auto-accept is also
// okay).
- PermissionBubbleManager::FromWebContents(new_tab)
- ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
+ PermissionRequestManager::FromWebContents(new_tab)
+ ->set_auto_response_for_test(PermissionRequestManager::ACCEPT_ALL);
GetUserMedia(new_tab, constraints);
std::string result;
EXPECT_TRUE(content::ExecuteScriptAndExtractString(
« no previous file with comments | « chrome/browser/media/webrtc_apprtc_browsertest.cc ('k') | chrome/browser/notifications/notification_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698