chrome/browser/ui/browser.cc - Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 0e77ef3b0f4e35e68c399352c80b8f1aa37c707d..39519544c8df67a06252595604997d394b10d618 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -68,6 +68,7 @@

#include "chrome/browser/memory/tab_manager_web_contents_data.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/pepper_broker_infobar_delegate.h"

+#include "chrome/browser/permissions/permission_request_manager.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_destroyer.h"

@@ -143,7 +144,6 @@

#include "chrome/browser/ui/unload_controller.h"

#include "chrome/browser/ui/validation_message_bubble.h"

#include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"

#include "chrome/browser/ui/webui/signin/login_ui_service.h"

#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"

#include "chrome/browser/ui/window_sizer/window_sizer.h"

@@ -1763,10 +1763,10 @@ void Browser::RegisterProtocolHandler(WebContents* web_contents,

window_->GetLocationBar()->UpdateContentSettingsIcons();

}

- PermissionBubbleManager* bubble_manager =

- PermissionBubbleManager::FromWebContents(web_contents);

- if (bubble_manager) {

- bubble_manager->AddRequest(

+ PermissionRequestManager* permission_request_manager =

+ PermissionRequestManager::FromWebContents(web_contents);

+ if (permission_request_manager) {

+ permission_request_manager->AddRequest(

new RegisterProtocolHandlerPermissionRequest(registry, handler,

url, user_gesture));

}