chrome/browser/ui/tab_helpers.cc - Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2081103002: Rename PermissionBubbleManager to PermissionRequestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 2981c676900ba05bc351b550f60950b1ea2eb1a6..95c8d4ccd44efab63d7037410cddf3b18e7bbf78 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -63,6 +63,7 @@

#include "components/offline_pages/offline_page_feature.h"

#else

#include "chrome/browser/banners/app_banner_manager_desktop.h"

+#include "chrome/browser/permissions/permission_request_manager.h"

#include "chrome/browser/plugins/plugin_observer.h"

#include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"

#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"

@@ -71,7 +72,6 @@

#include "chrome/browser/ui/sad_tab_helper.h"

#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"

#include "components/pdf/browser/pdf_web_contents_helper.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

#include "components/zoom/zoom_controller.h"

@@ -202,7 +202,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(

web_contents, std::unique_ptr<pdf::PDFWebContentsHelperClient>(

new ChromePDFWebContentsHelperClient()));

- PermissionBubbleManager::CreateForWebContents(web_contents);

+ PermissionRequestManager::CreateForWebContents(web_contents);

PluginObserver::CreateForWebContents(web_contents);

SadTabHelper::CreateForWebContents(web_contents);

safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);