Rename PermissionBubbleManager to PermissionRequestManager

chrome/chrome_tests_unit.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'chrome_unit_tests_sources': [
       # histograms.xml is analyzed by AboutFlagsHistogramTest, so this
       # dependency is needed to make commit bots run unit_tests on
       # histograms.xml changes.
       '../tools/metrics/histograms/histograms.xml',
@@ skipping 261 matching lines @@
       'browser/ui/find_bar/find_backend_unittest.cc',
       'browser/ui/login/login_handler_unittest.cc',
       'browser/ui/passwords/manage_passwords_state_unittest.cc',
       'browser/ui/passwords/manage_passwords_view_utils_unittest.cc',
       'browser/ui/passwords/password_manager_presenter_unittest.cc',
       'browser/ui/search_engines/keyword_editor_controller_unittest.cc',
       'browser/ui/sync/profile_signin_confirmation_helper_unittest.cc',
       'browser/ui/sync/sync_promo_ui_unittest.cc',
       'browser/ui/tests/ui_gfx_image_unittest.cc',
       'browser/ui/tests/ui_gfx_image_unittest.mm',
+      'browser/ui/website_settings/mock_permission_bubble_factory.cc',
+      'browser/ui/website_settings/mock_permission_bubble_factory.h',
+      'browser/ui/website_settings/mock_permission_bubble_view.cc',
+      'browser/ui/website_settings/mock_permission_bubble_view.h',
       'browser/ui/website_settings/website_settings_unittest.cc',
       'browser/ui/webui/browsing_history_handler_unittest.cc',
       'browser/ui/webui/fileicon_source_unittest.cc',
       'browser/ui/webui/local_state/local_state_ui_unittest.cc',
       'browser/ui/webui/log_web_ui_url_unittest.cc',
       'browser/update_client/chrome_update_query_params_delegate_unittest.cc',
       'browser/win/chrome_elf_init_unittest.cc',
       'browser/win/enumerate_modules_model_unittest.cc',
       'browser/win/private_working_set_snapshot_unittest.cc',
       'common/chrome_content_client_unittest.cc',
@@ skipping 62 matching lines @@
       'browser/permissions/permission_queue_controller_unittest.cc',
     ],
     'chrome_unit_tests_non_mobile_sources': [
       'browser/download/download_dir_policy_handler_unittest.cc',
       'browser/lifetime/keep_alive_registry_unittest.cc',
       'browser/renderer_context_menu/render_view_context_menu_test_util.cc',
       'browser/renderer_context_menu/render_view_context_menu_test_util.h',
       'browser/ui/autofill/country_combobox_model_unittest.cc',
       'browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc',
       'browser/ui/passwords/manage_passwords_ui_controller_unittest.cc',
-      'browser/ui/website_settings/mock_permission_bubble_factory.cc',
-      'browser/ui/website_settings/mock_permission_bubble_factory.h',
-      'browser/ui/website_settings/mock_permission_bubble_view.cc',
-      'browser/ui/website_settings/mock_permission_bubble_view.h',
     ],
     'chrome_unit_tests_spellchecker_sources': [
       'browser/spellchecker/feedback_sender_unittest.cc',
       'browser/spellchecker/feedback_unittest.cc',
       'browser/spellchecker/misspelling_unittest.cc',
       'browser/spellchecker/spellcheck_action_unittest.cc',
       'browser/spellchecker/spellcheck_custom_dictionary_unittest.cc',
       'browser/spellchecker/spellcheck_host_metrics_unittest.cc',
       'browser/spellchecker/spellcheck_message_filter_platform_mac_unittest.cc',
       'browser/spellchecker/spellcheck_message_filter_unittest.cc',
@@ skipping 1116 matching lines @@
       'browser/media_galleries/media_galleries_dialog_controller_test_util.h',
       'browser/media_galleries/media_galleries_permission_controller_unittest.cc',
       'browser/media_galleries/media_galleries_permissions_unittest.cc',
       'browser/media_galleries/media_galleries_preferences_unittest.cc',
       'browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc',
       'browser/media_galleries/win/mtp_device_object_enumerator_unittest.cc',
       'browser/memory/tab_manager_delegate_chromeos_unittest.cc',
       'browser/memory/tab_manager_unittest.cc',
       'browser/memory/tab_manager_web_contents_data_unittest.cc',
       'browser/net/firefox_proxy_settings_unittest.cc',
+      'browser/permissions/permission_request_manager_unittest.cc',
       'browser/platform_util_unittest.cc',
       'browser/power/process_power_collector_unittest.cc',
       'browser/process_singleton_posix_unittest.cc',
       'browser/profile_resetter/profile_resetter_unittest.cc',
       'browser/profile_resetter/triggered_profile_resetter_win_unittest.cc',
       'browser/renderer_context_menu/render_view_context_menu_unittest.cc',
       'browser/search/instant_service_unittest.cc',
       'browser/search/instant_unittest_base.cc',
       'browser/search/instant_unittest_base.h',
       'browser/search/search_unittest.cc',
@@ skipping 47 matching lines @@
       'browser/ui/toolbar/mock_component_toolbar_actions_factory.h',
       'browser/ui/toolbar/recent_tabs_builder_test_helper.cc',
       'browser/ui/toolbar/recent_tabs_builder_test_helper.h',
       'browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc',
       'browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc',
       'browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h',
       'browser/ui/toolbar/toolbar_actions_bar_unittest.cc',
       'browser/ui/toolbar/toolbar_actions_bar_unittest.h',
       'browser/ui/toolbar/toolbar_actions_model_unittest.cc',
       'browser/ui/toolbar/toolbar_model_unittest.cc',
-      'browser/ui/website_settings/permission_bubble_manager_unittest.cc',
       'browser/ui/website_settings/permission_menu_model_unittest.cc',
       'browser/ui/webui/help/version_updater_chromeos_unittest.cc',
       'browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc',
       'browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc',
       'browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc',
       'browser/ui/webui/options/autofill_options_handler_unittest.cc',
       'browser/ui/webui/options/language_options_handler_unittest.cc',
       'browser/ui/webui/options/password_manager_handler_unittest.cc',
       'browser/ui/webui/options/pepper_flash_content_settings_utils_unittest.cc',
       'browser/ui/webui/options/sync_setup_handler_unittest.cc',
@@ skipping 327 matching lines @@
             '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
           ],
           'export_dependent_settings': [
             'renderer',
           ],
         }, {  # OS=="ios"
           'sources/': [
             # Exclude everything but iOS-specific files.
             ['exclude', '\\.(cc|mm)$'],
             ['include', '_ios\\.(cc|mm)$'],
+            ['exclude', '^browser/ui/website_settings/mock_permission_bubble_request\\.(cc|h)$'],

[Lei Zhang, 2016/07/13 01:53:14]

Is there a "non-ios" list to put the files in instead? If iOS magically switches
to GN tomorrow, they aren't going to get this for free.

[Lei Zhang, 2016/07/13 02:04:24]

Actually, is this even needed? Doesn't line 1917 start off excluding everything?

[tsergeant, 2016/07/13 04:20:53]

Hmm, I think you're right.

The iOS trybots seem fine without it.

             ['include', '(^|/)ios/'],
             # TODO(ios): Add files here as they are updated to compile on iOS.
             ['include', '^test/base/chrome_test_suite\\.cc$'],
             ['include', '^test/base/chrome_unit_test_suite\\.cc$'],
             ['include', '^test/base/testing_browser_process'],
           ],
         }],
         ['OS=="ios" or OS=="android"', {
           'sources!': [
             'browser/ui/passwords/manage_passwords_ui_controller_mock.cc',
@@ skipping 1093 matching lines @@
               'dependencies': [
                 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
               ],
             }],
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }