Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed)

Created:
4 years, 6 months ago by vasilii
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, Xianzhu, pdr.
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@TrackInvalidation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Let FrameView track object paint invalidations (patchset #12 id:220001 of https://codereview.chromium.org/2051333005/ ) Reason for revert: Broke updating-scrolling-container-and-content on all the platforms https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43368 Original issue's description: > Let FrameView track object paint invalidations > > With client-side invalidation flags, PaintController no longer need to > track invalidation of clients for painting purpose. We also don't need > to distinguish on which GraphicsLayer a client is invalidated because > when it's invalidated it will be invalid on all GraphicsLayers. > > Let FrameView track object paint invalidations so that we don't need > to send object paint invalidations to backings. > > BUG=617799 > > Committed: https://crrev.com/5cdeb1b846e2f1c8bcab391e0b0ea55faf5c5b12 > Cr-Commit-Position: refs/heads/master@{#400605} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -1080 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 8 chunks +135 lines, -885 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 5 chunks +7 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 4 chunks +12 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 9 chunks +69 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 8 chunks +35 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 4 chunks +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 5 chunks +41 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vasilii
Created Revert of Let FrameView track object paint invalidations
4 years, 6 months ago (2016-06-20 08:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080593002/1
4 years, 6 months ago (2016-06-20 08:41:22 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 08:43:18 UTC) #5
Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Powered by Google App Engine
This is Rietveld 408576698