third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp - Issue 2080593002: Revert of Let FrameView track object paint invalidations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

index 4558b88dcaa34853c96606257d7d6a9362a8a1bc..202a06ec3a544304f8479de75e868293d11291c7 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

@@ -46,7 +46,8 @@

return;

// Must check DrawingRecorder::useCachedDrawingIfPossible before creating the DrawingRecorder.

- DCHECK(RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled()

+ ASSERT((RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && context.getPaintController().paintOffsetWasInvalidated(displayItemClient))

+ || RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled()

|| !useCachedDrawingIfPossible(m_context, m_displayItemClient, m_displayItemType));

ASSERT(DisplayItem::isDrawingType(displayItemType));