Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 919 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 || !m_collapsedBorderValues->endBorder.visuallyEquals(newValues.endB order) 930 || !m_collapsedBorderValues->endBorder.visuallyEquals(newValues.endB order)
931 || !m_collapsedBorderValues->beforeBorder.visuallyEquals(newValues.b eforeBorder) 931 || !m_collapsedBorderValues->beforeBorder.visuallyEquals(newValues.b eforeBorder)
932 || !m_collapsedBorderValues->afterBorder.visuallyEquals(newValues.af terBorder); 932 || !m_collapsedBorderValues->afterBorder.visuallyEquals(newValues.af terBorder);
933 if (changed) 933 if (changed)
934 *m_collapsedBorderValues = newValues; 934 *m_collapsedBorderValues = newValues;
935 } 935 }
936 936
937 // If collapsed borders changed, invalidate the cell's display item client o n the table's backing. 937 // If collapsed borders changed, invalidate the cell's display item client o n the table's backing.
938 // TODO(crbug.com/451090#c5): Need a way to invalidate/repaint the borders o nly. 938 // TODO(crbug.com/451090#c5): Need a way to invalidate/repaint the borders o nly.
939 if (changed) 939 if (changed)
940 table()->slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient( *this, PaintInvalidationStyleChange); 940 table()->invalidateDisplayItemClient(*this);
941 941
942 addBorderStyle(borderValues, newValues.startBorder); 942 addBorderStyle(borderValues, newValues.startBorder);
943 addBorderStyle(borderValues, newValues.endBorder); 943 addBorderStyle(borderValues, newValues.endBorder);
944 addBorderStyle(borderValues, newValues.beforeBorder); 944 addBorderStyle(borderValues, newValues.beforeBorder);
945 addBorderStyle(borderValues, newValues.afterBorder); 945 addBorderStyle(borderValues, newValues.afterBorder);
946 } 946 }
947 947
948 void LayoutTableCell::sortBorderValues(LayoutTable::CollapsedBorderValues& borde rValues) 948 void LayoutTableCell::sortBorderValues(LayoutTable::CollapsedBorderValues& borde rValues)
949 { 949 {
950 std::sort(borderValues.begin(), borderValues.end(), compareBorders); 950 std::sort(borderValues.begin(), borderValues.end(), compareBorders);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 bool LayoutTableCell::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localR ect) const 1009 bool LayoutTableCell::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localR ect) const
1010 { 1010 {
1011 // If this object has layer, the area of collapsed borders should be transpa rent 1011 // If this object has layer, the area of collapsed borders should be transpa rent
1012 // to expose the collapsed borders painted on the underlying layer. 1012 // to expose the collapsed borders painted on the underlying layer.
1013 if (hasLayer() && table()->collapseBorders()) 1013 if (hasLayer() && table()->collapseBorders())
1014 return false; 1014 return false;
1015 return LayoutBlockFlow::backgroundIsKnownToBeOpaqueInRect(localRect); 1015 return LayoutBlockFlow::backgroundIsKnownToBeOpaqueInRect(localRect);
1016 } 1016 }
1017 1017
1018 } // namespace blink 1018 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698