Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index ce1d5d8ff520e0ca933b14ef4e3446a1896b369a..478175a59ca7b6abd723721afdb2e433e27d994d 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -63,7 +63,6 @@
class Element;
class FloatSize;
class HTMLFrameOwnerElement;
-class JSONArray;
class LayoutPart;
class LocalFrame;
class KURL;
@@ -322,11 +321,8 @@
static void setInitialTracksPaintInvalidationsForTesting(bool);
- // These methods are for testing.
void setTracksPaintInvalidations(bool);
- bool isTrackingPaintInvalidations() const { return m_trackedObjectPaintInvalidations.get(); }
- void trackObjectPaintInvalidation(const DisplayItemClient&, PaintInvalidationReason);
- PassRefPtr<JSONArray> trackedObjectPaintInvalidationsAsJSON() const;
+ bool isTrackingPaintInvalidations() const { return m_isTrackingPaintInvalidations; }
using ScrollableAreaSet = HeapHashSet<Member<ScrollableArea>>;
void addScrollableArea(ScrollableArea*);
@@ -823,6 +819,8 @@
bool m_safeToPropagateScrollToParent;
+ bool m_isTrackingPaintInvalidations; // Used for testing.
+
unsigned m_visuallyNonEmptyCharacterCount;
unsigned m_visuallyNonEmptyPixelCount;
bool m_isVisuallyNonEmpty;
@@ -920,13 +918,6 @@
bool m_needsScrollbarsUpdate;
bool m_suppressAdjustViewSize;
bool m_inPluginUpdate;
-
- // For testing.
- struct ObjectPaintInvalidation {
- String name;
- PaintInvalidationReason reason;
- };
- OwnPtr<Vector<ObjectPaintInvalidation>> m_trackedObjectPaintInvalidations;
};
inline void FrameView::incrementVisuallyNonEmptyCharacterCount(unsigned count)
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698