third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp - Issue 2080593002: Revert of Let FrameView track object paint invalidations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp b/third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp

index 5d2144d0f7438fcadc37a349b125c3f157b2f4bb..0924dbddc50852a1fd3129f935d7a27de6498e8f 100644

--- a/third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp

@@ -60,8 +60,6 @@

static void invalidateLineBoxPaintOffsetsInternal(PaintController& paintController, InlineFlowBox* inlineBox)

{

-#if 0

- // TODO(wangxianzhu): Implement this with PaintInvalidator.

paintController.invalidatePaintOffset(*inlineBox);

for (InlineBox* child = inlineBox->firstChild(); child; child = child->nextOnLine()) {

if (!child->getLineLayoutItem().isText() && child->boxModelObject().hasSelfPaintingLayer())

@@ -71,7 +69,6 @@

else

paintController.invalidatePaintOffset(*child);

}

-#endif

}

void LineBoxListPainter::invalidateLineBoxPaintOffsets(const PaintInfo& paintInfo) const