Integers can now be passed as uniforms

Integers can now be passed as uniforms; needed for passing color count to fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed: https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
Committed: https://skia.googlesource.com/skia/+/497e9e2b3668fd8bc7fab16326e93c5cc6f0c287

[fmenozzi, 2016-06-17 21:11:22]

Description was changed from

==========
Integers can now be passed as uniforms

BUG=skia:
==========

to

==========
Integers can now be passed as uniforms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
==========

[fmenozzi, 2016-06-17 21:15:53]

Description was changed from

==========
Integers can now be passed as uniforms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
==========

to

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
==========

[fmenozzi, 2016-06-17 21:16:23]

fmenozzi@google.com changed reviewers:
+ bsalomon@google.com, tomhudson@google.com

[fmenozzi, 2016-06-17 21:16:24]

PTAL

[tomhudson, 2016-06-18 16:14:07]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-06-18 16:14:08]

lgtm

[commit-bot: I haz the power, 2016-06-18 16:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076143003/1

[commit-bot: I haz the power, 2016-06-18 16:32:03]

Description was changed from

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003
==========

to

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed:
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
==========

[commit-bot: I haz the power, 2016-06-18 16:32:04]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198

[egdaniel, 2016-06-18 21:17:58]

On 2016/06/18 16:32:04, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198

This change is breaking skia's vulkan builds. Looks like you need to update
GrVkProgramDataManager as well.

[Brian Osman, 2016-06-20 00:48:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2080133002/ by brianosman@google.com.

The reason for reverting is: Compile failures on Vulkan platforms (eg
https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Ar...).

[fmenozzi, 2016-06-20 14:09:18]

Description was changed from

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed:
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
==========

to

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed:
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
==========

[fmenozzi, 2016-06-20 15:17:45]

fmenozzi@google.com changed reviewers:
+ egdaniel@google.com

[fmenozzi, 2016-06-20 15:17:46]

PTAL

Added integer uniforms to Vulkan as well

[tomhudson, 2016-06-20 15:22:17]

I don't understand why we'd tell Federico to land an SkASSERT(false)?

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
File src/gpu/vk/GrVkPipelineStateDataManager.cpp (right):

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
src/gpu/vk/GrVkPipelineStateDataManager.cpp:59: SkASSERT(false);
Not happy.

[egdaniel, 2016-06-20 16:21:49]

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
File src/gpu/vk/GrVkPipelineStateDataManager.cpp (right):

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
src/gpu/vk/GrVkPipelineStateDataManager.cpp:59: SkASSERT(false);
oh sorry wire's got crossed. Since I've mentioned this, we know vulkan takes 32
bit ints. So we don't need the assert here. It was a way to unblock this CL
before he got to the point of actually landing a change that used this function.

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
File src/gpu/vk/GrVkPipelineStateDataManager.h (right):

https://codereview.chromium.org/2076143003/diff/40001/src/gpu/vk/GrVkPipeline...
src/gpu/vk/GrVkPipelineStateDataManager.h:11: #include <cstdint>
do we really not have int32_t accessable already?

[fmenozzi, 2016-06-20 16:54:48]

Remove unnecessary assert and header include

[tomhudson, 2016-06-20 16:56:28]

lgtm

[bsalomon, 2016-06-21 13:40:21]

lgtm if the Vulkan part lgt egdaniel@,

https://codereview.chromium.org/2076143003/diff/60001/src/gpu/vk/GrVkPipeline...
File src/gpu/vk/GrVkPipelineStateDataManager.cpp (right):

https://codereview.chromium.org/2076143003/diff/60001/src/gpu/vk/GrVkPipeline...
src/gpu/vk/GrVkPipelineStateDataManager.cpp:62: SkASSERT(sizeof(int32_t) == 4);
I question the need for this assert... but if we're going to have it then it
should probably be a static assert.

[egdaniel, 2016-06-21 13:42:00]

lgtm

[fmenozzi, 2016-06-21 13:46:24]

The CQ bit was checked by fmenozzi@google.com

[fmenozzi, 2016-06-21 13:46:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
egdaniel@google.com, tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/2076143003/#ps80001
(title: "Remove unnecessary assert")

[commit-bot: I haz the power, 2016-06-21 13:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076143003/80001

[commit-bot: I haz the power, 2016-06-21 14:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 14:05:45]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[fmenozzi, 2016-06-21 16:33:49]

The CQ bit was checked by fmenozzi@google.com

[commit-bot: I haz the power, 2016-06-21 16:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2076143003/80001

[commit-bot: I haz the power, 2016-06-21 16:42:15]

Description was changed from

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed:
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
==========

to

==========
Integers can now be passed as uniforms; needed for passing color count to
fragment shader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2076143003

Committed:
https://skia.googlesource.com/skia/+/cc3a22b369e1a60fa2acf2987f2934baf7c4b198
Committed:
https://skia.googlesource.com/skia/+/497e9e2b3668fd8bc7fab16326e93c5cc6f0c287
==========

[commit-bot: I haz the power, 2016-06-21 16:42:16]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/497e9e2b3668fd8bc7fab16326e93c5cc6f0c287