Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 207523005: ARM: Fix Q register encoding (Closed)

Created:
6 years, 9 months ago by m.m.capewell
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix Q register encoding Fix Q register encoding for registers other than Q0. Also, fix value in NeonSize enumeration. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 4 chunks +20 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
A fix for the problem described here: https://groups.google.com/forum/#!topic/v8-users/tSz5GBOEmqM
6 years, 9 months ago (2014-03-21 10:25:36 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-21 12:26:26 UTC) #2
m.m.capewell
6 years, 9 months ago (2014-03-21 13:04:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698