[Password Generation] Run the form classifier only if AutofillMetadata is enabled

[Password Generation] Run the form classifier only ifAutofillMetadata is enabled (i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434
Committed: https://crrev.com/fe729f044a13f6f476aba98b079304f54bc0d96a
Cr-Commit-Position: refs/heads/master@{#400954}

[kolos1, 2016-06-20 08:31:43]

Description was changed from

==========
[Password Generation] Run the fomr classifier only AutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it stable to decrease performance load.

BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only AutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it stable to decrease performance load.

BUG=582434
==========

[kolos1, 2016-06-20 08:39:57]

Description was changed from

==========
[Password Generation] Run the form classifier only AutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it stable to decrease performance load.

BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only AutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

BUG=582434
==========

[kolos1, 2016-06-20 10:52:39]

Patchset #1 (id:1) has been deleted

[kolos1, 2016-06-20 10:52:46]

Patchset #1 (id:20001) has been deleted

[kolos1, 2016-06-20 10:52:51]

Patchset #1 (id:40001) has been deleted

[kolos1, 2016-06-20 10:59:18]

kolos@chromium.org changed reviewers:
+ vabr@chromium.org

[kolos1, 2016-06-20 10:59:19]

Hi Vaclav,

Please review this CL.

Best regards,
Maxim

[kolos1, 2016-06-20 11:27:59]

Description was changed from

==========
[Password Generation] Run the form classifier only AutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

BUG=582434
==========

[vabr (Chromium), 2016-06-20 12:14:11]

LGTM, thank you.
Vaclav

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File
components/password_manager/core/browser/password_generation_manager_unittest.cc
(right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_generation_manager_unittest.cc:267:
bool falseTrue[] = {false, true};
nit: Wrong naming format; better: false_true.

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File components/password_manager/core/browser/password_manager_driver.h (right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_manager_driver.h:100: virtual
void AllowToRunFormClassifier(){};
nit: Please format (missing space before {}).

[kolos1, 2016-06-20 12:25:15]

kolos@chromium.org changed reviewers:
+ mkwst@chromium.org

[kolos1, 2016-06-20 12:25:16]

mkwst@: Please review changes in
components/autofill/content/common/autofill_messages.h

vabr@: replied to your comments. Please review.

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File
components/password_manager/core/browser/password_generation_manager_unittest.cc
(right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_generation_manager_unittest.cc:267:
bool falseTrue[] = {false, true};
On 2016/06/20 12:14:11, vabr (Chromium) wrote:
> nit: Wrong naming format; better: false_true.

Fixed to "const bool kFalseTrue[] = {false, true};"

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File components/password_manager/core/browser/password_manager_driver.h (right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_manager_driver.h:100: virtual
void AllowToRunFormClassifier(){};
On 2016/06/20 12:14:11, vabr (Chromium) wrote:
> nit: Please format (missing space before {}).

Done.

Git formatter surprisingly removes this space.

[vabr (Chromium), 2016-06-20 12:36:55]

Still LGTM, but one more comment.

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File
components/password_manager/core/browser/password_generation_manager_unittest.cc
(right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_generation_manager_unittest.cc:267:
bool falseTrue[] = {false, true};
On 2016/06/20 12:25:16, kolos1 wrote:
> On 2016/06/20 12:14:11, vabr (Chromium) wrote:
> > nit: Wrong naming format; better: false_true.
> 
> Fixed to "const bool kFalseTrue[] = {false, true};"

Acknowledged.

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File components/password_manager/core/browser/password_manager_driver.h (right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_manager_driver.h:100: virtual
void AllowToRunFormClassifier(){};
On 2016/06/20 12:25:16, kolos1 wrote:
> On 2016/06/20 12:14:11, vabr (Chromium) wrote:
> > nit: Please format (missing space before {}).
> 
> Done.
> 
> Git formatter surprisingly removes this space. 

That is probably because of the unnecessary ';' at the end. Please try to remove
the ';' and reformat.

[kolos1, 2016-06-20 12:49:04]

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
File components/password_manager/core/browser/password_manager_driver.h (right):

https://codereview.chromium.org/2073143002/diff/80001/components/password_man...
components/password_manager/core/browser/password_manager_driver.h:100: virtual
void AllowToRunFormClassifier(){};
On 2016/06/20 12:36:55, vabr (Chromium) wrote:
> On 2016/06/20 12:25:16, kolos1 wrote:
> > On 2016/06/20 12:14:11, vabr (Chromium) wrote:
> > > nit: Please format (missing space before {}).
> > 
> > Done.
> > 
> > Git formatter surprisingly removes this space. 
> 
> That is probably because of the unnecessary ';' at the end. Please try to
remove
> the ';' and reformat.

Thanks. That works.

[kolos1, 2016-06-20 13:08:31]

Patchset #4 (id:120001) has been deleted

[kolos1, 2016-06-21 07:34:26]

mkwst@: Friendly ping, please review one new message in
components/autofill/content/common/autofill_messages.h

[Mike West, 2016-06-21 10:42:55]

IPC LGTM.

(Do y'all have a plan to start migrating to Mojo?)

[kolos1, 2016-06-21 10:48:11]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2016-06-21 10:48:12]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2073143002/#ps140001
(title: "Removed unnecessary ';'")

[commit-bot: I haz the power, 2016-06-21 10:48:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073143002/140001

[vabr (Chromium), 2016-06-21 10:50:00]

On 2016/06/21 10:42:55, Mike West (OOO - BlinkOn) wrote:
> IPC LGTM.
> 
> (Do y'all have a plan to start migrating to Mojo?)

Not just a plan, we have a person actively doing it. Credential Manager, as an
example, is on Mojo already. http://crbug.com/582391 :)

[commit-bot: I haz the power, 2016-06-21 10:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 10:55:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-06-21 11:04:57]

Description was changed from

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434
==========

[vabr (Chromium), 2016-06-21 11:07:06]

There is an error in the presubmit check. It thinks the the OWNERS file for
autofill is wrong. See more in https://codereview.chromium.org/2086803003/.

This CL has nothing to do with that presubmit issue, and has all needed
approvals, so I modified the CL description to skip the hooks
(NOPRESUBMIT=true).

Cheers,
Vaclav

[vabr (Chromium), 2016-06-21 11:07:18]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-06-21 11:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073143002/140001

[commit-bot: I haz the power, 2016-06-21 11:33:53]

Description was changed from

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434
==========

[commit-bot: I haz the power, 2016-06-21 11:33:54]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-06-21 11:39:49]

Description was changed from

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434
==========

to

==========
[Password Generation] Run the form classifier only ifAutofillMetadata is enabled
(i.e. only in dev and canary)

Since the classifier always returns the same response fo the given form, don't
run it in stable to decrease performance load.

NOPRESUBMIT=true
BUG=582434

Committed: https://crrev.com/fe729f044a13f6f476aba98b079304f54bc0d96a
Cr-Commit-Position: refs/heads/master@{#400954}
==========

[commit-bot: I haz the power, 2016-06-21 11:39:50]

Patchset 4 (id:??) landed as
https://crrev.com/fe729f044a13f6f476aba98b079304f54bc0d96a
Cr-Commit-Position: refs/heads/master@{#400954}