[Password Generation] Run the form classifier only if AutofillMetadata is enabled

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 54 matching lines @@
         render_thread_->sink().GetFirstMessageMatching(
             AutofillHostMsg_ShowPasswordGenerationPopup::ID);
     if (available)
       ASSERT_TRUE(message);
     else
       ASSERT_FALSE(message);
 
     render_thread_->sink().ClearMessages();
   }
 
+  void AllowToRunFormClassifier() {
+    AutofillMsg_AllowToRunFormClassifier msg(0);
+    static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
+  }
+
   void ExpectFormClassifierVoteReceived(
+      bool received,
       const base::string16& expected_generation_element) {
     const IPC::Message* message =
         render_thread_->sink().GetFirstMessageMatching(
             AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::ID);
-    ASSERT_TRUE(message);
-    std::tuple<autofill::PasswordForm, base::string16> actual_parameters;
-    AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::Read(
-        message, &actual_parameters);
-    EXPECT_EQ(expected_generation_element, std::get<1>(actual_parameters));
+    if (received) {
+      ASSERT_TRUE(message);
+      std::tuple<autofill::PasswordForm, base::string16> actual_parameters;
+      AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::Read(
+          message, &actual_parameters);
+      EXPECT_EQ(expected_generation_element, std::get<1>(actual_parameters));
+    } else {
+      ASSERT_FALSE(message);
+    }
+
     render_thread_->sink().ClearMessages();
   }
 
   void ShowGenerationPopUpManually(const char* element_id) {
     FocusField(element_id);
     AutofillMsg_UserTriggeredGeneratePassword msg(0);
     static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
   }
 
  private:
@@ skipping 559 matching lines @@
     for (size_t i = 0; i < password.length(); ++i)
       SimulateUserTypingASCIICharacter(ui::VKEY_BACK, false);
     SimulateUserTypingASCIICharacter(ui::VKEY_BACK, true);
     EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
         AutofillHostMsg_PasswordNoLongerGenerated::ID));
     render_thread_->sink().ClearMessages();
   }
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSignupForm) {
+  AllowToRunFormClassifier();
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
-  ExpectFormClassifierVoteReceived(base::ASCIIToUTF16("first_password"));
+  ExpectFormClassifierVoteReceived(true /* vote is expected */,
+                                   base::ASCIIToUTF16("first_password"));
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSigninForm) {
+  AllowToRunFormClassifier();
   LoadHTMLWithUserGesture(kSigninFormHTML);
-  ExpectFormClassifierVoteReceived(base::string16());
+  ExpectFormClassifierVoteReceived(true /* vote is expected */,
+                                   base::string16());
+}
+
+TEST_F(PasswordGenerationAgentTest, FormClassifierDisabled) {
+  LoadHTMLWithUserGesture(kSigninFormHTML);
+  ExpectFormClassifierVoteReceived(false /* vote is not expected */,
+                                   base::string16());
 }
 
 }  // namespace autofill