Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2073143002: [Password Generation] Run the form classifier only if AutofillMetadata is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_classifier_votes
Patch Set: Removed unnecessary ';' Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 15b406fe697257d5f84b531c173572c5526bffb2..0a7769436f04f191021aaed2f722c4d5e8247df4 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -136,6 +136,11 @@ void ContentPasswordManagerDriver::SendLoggingAvailability() {
client_->GetLogManager()->IsLoggingActive()));
}
+void ContentPasswordManagerDriver::AllowToRunFormClassifier() {
+ render_frame_host_->Send(new AutofillMsg_AllowToRunFormClassifier(
+ render_frame_host_->GetRoutingID()));
+}
+
PasswordGenerationManager*
ContentPasswordManagerDriver::GetPasswordGenerationManager() {
return &password_generation_manager_;
@@ -194,6 +199,7 @@ void ContentPasswordManagerDriver::OnPasswordFormsParsed(
void ContentPasswordManagerDriver::OnPasswordFormsParsedNoRenderCheck(
const std::vector<autofill::PasswordForm>& forms) {
GetPasswordManager()->OnPasswordFormsParsed(this, forms);
+ GetPasswordGenerationManager()->CheckIfFormClassifierShouldRun();
}
void ContentPasswordManagerDriver::OnPasswordFormsRendered(

Powered by Google App Engine
This is Rietveld 408576698