components/password_manager/core/browser/password_generation_manager.h - Issue 2073143002: [Password Generation] Run the form classifier only if AutofillMetadata is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.h

Issue 2073143002: [Password Generation] Run the form classifier only if AutofillMetadata is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_classifier_votes

Patch Set: Removed unnecessary ';' Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | components/password_manager/core/browser/password_generation_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.h

diff --git a/components/password_manager/core/browser/password_generation_manager.h b/components/password_manager/core/browser/password_generation_manager.h

index 6f2fe47efe51610f0dac642784c7c4611fcb2b71..c683b1865bad1a27f49918bb985f18037fee8a36 100644

--- a/components/password_manager/core/browser/password_generation_manager.h

+++ b/components/password_manager/core/browser/password_generation_manager.h

@@ -46,6 +46,12 @@ class PasswordGenerationManager {

// Determines current state of password generation

bool IsGenerationEnabled() const;

+ // Determine if the form classifier should run. If yes, sends a message to the

+ // renderer.

+ // TODO(crbug.com/621442): Remove client-side form classifier when server-side

+ // classifier is ready.

+ void CheckIfFormClassifierShouldRun();

private:

friend class PasswordGenerationManagerTest;