components/password_manager/core/browser/password_generation_manager.cc - Issue 2073143002: [Password Generation] Run the form classifier only if AutofillMetadata is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 2073143002: [Password Generation] Run the form classifier only if AutofillMetadata is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_classifier_votes

Patch Set: Removed unnecessary ';' Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_generation_manager.h ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.cc

diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc

index 637abdeea1a0c563af43342d7c366b58c51f3cc5..d1b364127922e52a75cb1f0169154becc7a1fdaa 100644

--- a/components/password_manager/core/browser/password_generation_manager.cc

+++ b/components/password_manager/core/browser/password_generation_manager.cc

@@ -71,4 +71,9 @@ bool PasswordGenerationManager::IsGenerationEnabled() const {

return true;

}

+void PasswordGenerationManager::CheckIfFormClassifierShouldRun() {

+ if (autofill::FormStructure::IsAutofillFieldMetadataEnabled())

+ driver_->AllowToRunFormClassifier();

} // namespace password_manager