Implement byte swapping instructions on MIPS32 and MIPS64.

Implement byte swapping instructions on MIPS32 and MIPS64.

BUG=

Committed: https://crrev.com/e1e50f3fff84af3a31133025d8c68b5d76b5ee52
Cr-Commit-Position: refs/heads/master@{#37295}

[ivica.bogosavljevic, 2016-06-15 14:39:24]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, gergely.kis@imgtec.com,
ilija.pavlovic.imgtec@gmail.com

[ivica.bogosavljevic, 2016-06-15 14:39:25]

PTAL

Need this in order to support WASM on big-endian effectively

[balazs.kilvady, 2016-06-21 10:24:58]

Loloks good. So far I just took a quick look to the 32-bit part and have nits:

https://codereview.chromium.org/2069933003/diff/1/src/mips/macro-assembler-mi...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/2069933003/diff/1/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:1195: if (IsMipsArchVariant(kMips32r2) ||
IsMipsArchVariant(kMips32r6)) {
Please use { and } in the below if instructions.

https://codereview.chromium.org/2069933003/diff/1/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:1240: if (IsMipsArchVariant(kMips32r2) ||
IsMipsArchVariant(kMips32r6)) {
{}

https://codereview.chromium.org/2069933003/diff/1/src/mips/simulator-mips.cc
File src/mips/simulator-mips.cc (right):

https://codereview.chromium.org/2069933003/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:3838: int32_t output = 0x000000FF & input;
In the above line if input is an int8_t then why do you mask it? Is it needed?
Question for all the similar masks below.

[balazs.kilvady, 2016-06-27 09:25:55]

lgtm with minor nits.

https://codereview.chromium.org/2069933003/diff/20001/test/cctest/test-macro-...
File test/cctest/test-macro-assembler-mips.cc (right):

https://codereview.chromium.org/2069933003/diff/20001/test/cctest/test-macro-...
test/cctest/test-macro-assembler-mips.cc:68: typedef struct {
Please use struct T {}; In C++ no need to typedef a struct, that is a type
already.

https://codereview.chromium.org/2069933003/diff/20001/test/cctest/test-macro-...
File test/cctest/test-macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2069933003/diff/20001/test/cctest/test-macro-...
test/cctest/test-macro-assembler-mips64.cc:70: typedef struct {
Same note as in the 32-bit version.

[ivica.bogosavljevic, 2016-06-27 14:03:56]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 14:04:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 14:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 14:28:21]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-06-27 14:32:53]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[ivica.bogosavljevic, 2016-06-27 14:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
balazs.kilvady@imgtec.com
Link to the patchset: https://codereview.chromium.org/2069933003/#ps40001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-06-27 14:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 14:35:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-27 14:36:54]

Description was changed from

==========
Implement byte swapping instructions on MIPS32 and MIPS64.

BUG=
==========

to

==========
Implement byte swapping instructions on MIPS32 and MIPS64.

BUG=

Committed: https://crrev.com/e1e50f3fff84af3a31133025d8c68b5d76b5ee52
Cr-Commit-Position: refs/heads/master@{#37295}
==========

[commit-bot: I haz the power, 2016-06-27 14:36:55]

Patchset 3 (id:??) landed as
https://crrev.com/e1e50f3fff84af3a31133025d8c68b5d76b5ee52
Cr-Commit-Position: refs/heads/master@{#37295}