Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2068423002: Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl (Closed)

Created:
4 years, 6 months ago by Ryan Hamilton
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ClearAlternativeServices
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl Committed: https://crrev.com/0ddd7e156a1db26ec0453f7e8ad16c86ec2b244f Cr-Commit-Position: refs/heads/master@{#400153}

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -44 lines) Patch
M net/http/http_server_properties_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 5 chunks +25 lines, -36 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Ryan Hamilton
4 years, 6 months ago (2016-06-15 23:19:18 UTC) #2
ramant (doing other things)
lgtm
4 years, 6 months ago (2016-06-15 23:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068423002/20001
4 years, 6 months ago (2016-06-16 13:50:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 14:37:51 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 14:38:00 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 14:39:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ddd7e156a1db26ec0453f7e8ad16c86ec2b244f
Cr-Commit-Position: refs/heads/master@{#400153}

Powered by Google App Engine
This is Rietveld 408576698