net/http/http_server_properties_impl_unittest.cc - Issue 2068423002: Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_impl_unittest.cc

Issue 2068423002: Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ClearAlternativeServices

Patch Set: fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_server_properties_impl_unittest.cc

diff --git a/net/http/http_server_properties_impl_unittest.cc b/net/http/http_server_properties_impl_unittest.cc

index 9bbc183ded1c3ea10a2b0e24a4d5ec90858647ca..c566005d251fe19fe64da1b4a53394801939af9a 100644

--- a/net/http/http_server_properties_impl_unittest.cc

+++ b/net/http/http_server_properties_impl_unittest.cc

@@ -897,9 +897,9 @@ TEST_F(AlternateProtocolServerPropertiesTest, Canonical) {

alternative_service_vector[1].port);

// Verify the canonical suffix.

- EXPECT_EQ(".c.youtube.com", impl_.GetCanonicalSuffix(test_server.host()));

+ EXPECT_EQ(".c.youtube.com", *impl_.GetCanonicalSuffix(test_server.host()));

EXPECT_EQ(".c.youtube.com",

- impl_.GetCanonicalSuffix(canonical_server.host()));

+ *impl_.GetCanonicalSuffix(canonical_server.host()));

}

TEST_F(AlternateProtocolServerPropertiesTest, ClearCanonical) {

« no previous file with comments | « net/http/http_server_properties_impl.cc ('k') | net/http/http_server_properties_manager.cc » ('j') | no next file with comments »