net/http/http_server_properties_impl.h - Issue 2068423002: Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_impl.h

Issue 2068423002: Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ClearAlternativeServices

Patch Set: fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_server_properties_impl.h

diff --git a/net/http/http_server_properties_impl.h b/net/http/http_server_properties_impl.h

index 32c5f36a08d50fd3025188b8740d1fc1f244c72b..116b81f6625e85a35a905f172a676bb5cbbda4bb 100644

--- a/net/http/http_server_properties_impl.h

+++ b/net/http/http_server_properties_impl.h

@@ -69,9 +69,9 @@ class NET_EXPORT HttpServerPropertiesImpl

// unittests.

static std::string GetFlattenedSpdyServer(const HostPortPair& host_port_pair);

- // Returns the canonical host suffix for |host|, or std::string() if none

+ // Returns the canonical host suffix for |host|, or nullptr if none

// exists.

- std::string GetCanonicalSuffix(const std::string& host);

+ const std::string* GetCanonicalSuffix(const std::string& host) const;

// -----------------------------

// HttpServerProperties methods:

« no previous file with comments | « no previous file | net/http/http_server_properties_impl.cc » ('j') | no next file with comments »