Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2070203002: Remove unused HttpServerProperites::ClearAlternativeServices (Closed)

Created:
4 years, 6 months ago by Ryan Hamilton
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Bence
Base URL:
https://chromium.googlesource.com/chromium/src.git@AltSvcClear
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused HttpServerProperites::ClearAlternativeServices and inline HttpServerProperitesImpl::ClearAlternativeServices. BUG= Committed: https://crrev.com/ceef6c46ab40242049526f55d81c9401b84087ab Cr-Commit-Position: refs/heads/master@{#400087}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -58 lines) Patch
M net/http/http_server_properties.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 chunks +6 lines, -14 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Ryan Hamilton
rtenneti: PTAL bnc: FYI
4 years, 6 months ago (2016-06-15 23:12:12 UTC) #2
ramant (doing other things)
lgtm
4 years, 6 months ago (2016-06-15 23:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070203002/20001
4 years, 6 months ago (2016-06-16 05:02:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 05:06:35 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 05:06:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 05:08:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceef6c46ab40242049526f55d81c9401b84087ab
Cr-Commit-Position: refs/heads/master@{#400087}

Powered by Google App Engine
This is Rietveld 408576698