Cleanup usage of canonical_suffixes in HttpServerPropertiesImpl

net/http/http_server_properties_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties_manager.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 935 matching lines @@
       }
       if (IsAlternativeServiceBroken(alternative_service)) {
         continue;
       }
       notbroken_alternative_service_info_vector.push_back(
           alternative_service_info);
     }
     if (notbroken_alternative_service_info_vector.empty()) {
       continue;
     }
-    std::string canonical_suffix =
+    const std::string* canonical_suffix =
         http_server_properties_impl_->GetCanonicalSuffix(server.host());
-    if (!canonical_suffix.empty()) {
-      if (persisted_map.find(canonical_suffix) != persisted_map.end())
+    if (canonical_suffix != nullptr) {
+      if (persisted_map.find(*canonical_suffix) != persisted_map.end())
         continue;
-      persisted_map[canonical_suffix] = true;
+      persisted_map[*canonical_suffix] = true;
     }
     alternative_service_map->Put(server,
                                  notbroken_alternative_service_info_vector);
     ++count;
   }
 
   ServerNetworkStatsMap* server_network_stats_map =
       new ServerNetworkStatsMap(kMaxServerNetworkStatsHostsToPersist);
   const ServerNetworkStatsMap& network_stats_map =
       http_server_properties_impl_->server_network_stats_map();
@@ skipping 280 matching lines @@
                                                        quic_servers_dict);
 }
 
 void HttpServerPropertiesManager::OnHttpServerPropertiesChanged() {
   DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
   if (!setting_prefs_)
     ScheduleUpdateCacheOnPrefThread();
 }
 
 }  // namespace net