Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206813002: Remove GN GYP generator. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, dmikurube+memory_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Remove GN GYP generator. This removes the GYP generator code and associated build stuff. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2347 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M base/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M base/third_party/dynamic_annotations/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/nspr/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/symbolize/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/xdg_mime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/xdg_user_dirs/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/re2/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gn/BUILD.gn View 5 chunks +2 lines, -25 lines 0 comments Download
M tools/gn/action_target_generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gn/binary_target_generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/gn/command_gyp.cc View 1 chunk +0 lines, -553 lines 0 comments Download
M tools/gn/commands.h View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/gn/commands.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/copy_target_generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gn/function_toolchain.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/gn/functions_target.cc View 2 chunks +1 line, -2 lines 0 comments Download
M tools/gn/gn.gyp View 3 chunks +0 lines, -11 lines 0 comments Download
M tools/gn/group_target_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
D tools/gn/gyp_action_target_writer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/gn/gyp_action_target_writer.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D tools/gn/gyp_action_target_writer_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/gn/gyp_binary_target_writer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D tools/gn/gyp_binary_target_writer.cc View 1 chunk +0 lines, -773 lines 0 comments Download
D tools/gn/gyp_binary_target_writer_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D tools/gn/gyp_helper.h View 1 chunk +0 lines, -41 lines 0 comments Download
D tools/gn/gyp_helper.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D tools/gn/gyp_target_writer.h View 1 chunk +0 lines, -98 lines 0 comments Download
D tools/gn/gyp_target_writer.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
M tools/gn/secondary/components/language_usage_metrics/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/components/navigation_metrics/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/components/onc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/components/startup_metric_utils/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/components/translate/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/secondary/crypto/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/gn/secondary/ipc/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/secondary/net/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/gn/secondary/net/third_party/nss/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/sdch/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/skia/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/testing/gmock/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/icu/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/secondary/third_party/leveldatabase/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/libevent/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/libusb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/libxml/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/mach_override/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/modp_b64/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/wtl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/secondary/third_party/zlib/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/secondary/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/target.h View 3 chunks +0 lines, -8 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/target_generator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/target_generator.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M tools/gn/toolchain.h View 2 chunks +0 lines, -7 lines 0 comments Download
M tools/gn/variables.h View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/gn/variables.cc View 3 chunks +0 lines, -46 lines 0 comments Download
M url/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 9 months ago (2014-03-20 20:05:11 UTC) #1
scottmg
lgtm
6 years, 9 months ago (2014-03-20 20:10:09 UTC) #2
brettw
6 years, 9 months ago (2014-03-27 21:08:40 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r259983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698