Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/gn/action_target_generator.cc

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/binary_target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/action_target_generator.cc
diff --git a/tools/gn/action_target_generator.cc b/tools/gn/action_target_generator.cc
index 5f8f959f6308a3677f1fe184b3709e28146cc7f8..c51910c61b03752a7774e7dfa21627565dd95b1d 100644
--- a/tools/gn/action_target_generator.cc
+++ b/tools/gn/action_target_generator.cc
@@ -44,10 +44,6 @@ ActionTargetGenerator::~ActionTargetGenerator() {
void ActionTargetGenerator::DoRun() {
target_->set_output_type(output_type_);
- FillExternal();
- if (err_->has_error())
- return;
-
FillSources();
if (err_->has_error())
return;
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/binary_target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698