Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/gn/secondary/chrome/BUILD.gn

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gyp_target_writer.cc ('k') | tools/gn/secondary/components/language_usage_metrics/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/chrome/BUILD.gn
diff --git a/tools/gn/secondary/chrome/BUILD.gn b/tools/gn/secondary/chrome/BUILD.gn
index 1728a83c81db6d1f575125bce35df031091a2965..086fac566791d18843087dbc574da2d23061e31c 100644
--- a/tools/gn/secondary/chrome/BUILD.gn
+++ b/tools/gn/secondary/chrome/BUILD.gn
@@ -64,8 +64,6 @@ executable("chrome") {
}
static_library("browser") {
- external = true
-
if (is_linux) {
if (toolkit_uses_gtk) {
libs = [ "gconf-2" ]
@@ -83,8 +81,6 @@ static_library("browser") {
}
static_library("common") {
- external = true
-
if (use_nss && is_linux) {
# common/net uses NSS.
# TODO(brettw) have a better way to express this without having to do
@@ -170,15 +166,12 @@ source_set("debugger") {
}
source_set("plugin") {
- external = true
}
source_set("renderer") {
- external = true
}
source_set("utility") {
- external = true
}
« no previous file with comments | « tools/gn/gyp_target_writer.cc ('k') | tools/gn/secondary/components/language_usage_metrics/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698