Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: url/BUILD.gn

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/variables.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/BUILD.gn
diff --git a/url/BUILD.gn b/url/BUILD.gn
index e32d43436612c1ee6983b43845aec201daf58c54..131bfd5b23b763c1c223995752db9aea3ba4d3e6 100644
--- a/url/BUILD.gn
+++ b/url/BUILD.gn
@@ -3,7 +3,6 @@
# found in the LICENSE file.
component("url") {
- external = true
if (is_win) {
# Don't conflict with Windows' "url.dll".
output_name = "url_lib"
@@ -57,7 +56,6 @@ component("url") {
}
test("url_unittests") {
- external = true
sources = [
"gurl_unittest.cc",
"url_canon_unittest.cc",
« no previous file with comments | « tools/gn/variables.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698