Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/re2/BUILD.gn

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/third_party/xdg_user_dirs/BUILD.gn ('k') | tools/gn/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/re2/BUILD.gn
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
index 125904895b1638cbb617265e187508eca98b8987..f1716525cb777ae806257d1e5c2947414ac7f1ee 100644
--- a/third_party/re2/BUILD.gn
+++ b/third_party/re2/BUILD.gn
@@ -2,15 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# TODO(brettw) use this value when we remove external=true below.
-#gyp_file = "//$gyp_output_dir/gn_gyp/third_party/re2/re2.gyp"
-
config("re2_config") {
include_dirs = [ "." ]
}
static_library("re2") {
- external = true
sources = [
"mswin/stdint.h",
"re2/bitstate.cc",
« no previous file with comments | « base/third_party/xdg_user_dirs/BUILD.gn ('k') | tools/gn/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698