Begin instanced rendering for simple shapes

Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed: https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
Committed: https://skia.googlesource.com/skia/+/a7f29640f6ab4eb50962a9d9f12d01ac2ce8b471

[csmartdalton, 2016-06-15 19:40:17]

Description was changed from

==========
Implement instanced rendering for simple shapes

<TODO>

BUG=skia:
==========

to

==========
Implement instanced rendering for simple shapes

<TODO>

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

[csmartdalton, 2016-06-15 19:46:52]

csmartdalton@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com, robertphillips@google.com

[csmartdalton, 2016-06-15 19:46:53]

Hopefully this one is simpler than the last one. I still need to put in a real
commit message and pre-gild the diffs  but it's ready for another round of
reviews.

 I'm curious what you think about how the namespace is handled.

[bsalomon, 2016-06-20 14:48:52]

On 2016/06/15 19:46:53, csmartdalton wrote:
> Hopefully this one is simpler than the last one. I still need to put in a real
> commit message and pre-gild the diffs  but it's ready for another round of
> reviews.
> 
>  I'm curious what you think about how the namespace is handled.

lgtm

I'm glad to see us starting to use namespaces. I think it may take a little bit
to settle on conventions, but it should be easy to retrofit existing namespaces
to whatever the final convention is we adopt.

[bsalomon, 2016-06-20 14:49:54]

https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
File src/gpu/instanced/InstancedRenderingTypes.h (right):

https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
src/gpu/instanced/InstancedRenderingTypes.h:91: enum AttribIdx {
You could make these enum classes if you wanted. I believe most newer enums are
being added as enum classes.

[csmartdalton, 2016-06-20 15:33:47]

https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
File src/gpu/instanced/InstancedRenderingTypes.h (right):

https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
src/gpu/instanced/InstancedRenderingTypes.h:91: enum AttribIdx {
On 2016/06/20 14:49:54, bsalomon wrote:
> You could make these enum classes if you wanted. I believe most newer enums
are
> being added as enum classes.

Yeah AttribIdx should be made into an enum class with a few explicit "(int)"
casts. But what are we doing for bitfields like ShapeFlags and InfoMasks? It's
nice to have them grouped together in something like an enum, but since they can
combine they aren't pure enums like the enum classes try to enforce.

[bsalomon, 2016-06-20 15:38:31]

On 2016/06/20 15:33:47, csmartdalton wrote:
>
https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
> File src/gpu/instanced/InstancedRenderingTypes.h (right):
> 
>
https://codereview.chromium.org/2066993003/diff/80001/src/gpu/instanced/Insta...
> src/gpu/instanced/InstancedRenderingTypes.h:91: enum AttribIdx {
> On 2016/06/20 14:49:54, bsalomon wrote:
> > You could make these enum classes if you wanted. I believe most newer enums
> are
> > being added as enum classes.
> 
> Yeah AttribIdx should be made into an enum class with a few explicit "(int)"
> casts. But what are we doing for bitfields like ShapeFlags and InfoMasks? It's
> nice to have them grouped together in something like an enum, but since they
can
> combine they aren't pure enums like the enum classes try to enforce.

Ah, true enough. I'd keep them as regular old enums.

[csmartdalton, 2016-06-28 20:02:47]

Description was changed from

==========
Implement instanced rendering for simple shapes

<TODO>

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Desktop GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more types of shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

[csmartdalton, 2016-06-28 20:03:48]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Desktop GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more types of shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Desktop GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

[csmartdalton, 2016-06-29 16:34:25]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Desktop GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on a few GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

[csmartdalton, 2016-06-30 18:34:43]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on a few GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

[csmartdalton, 2016-06-30 18:37:53]

This change is all traiged now and ready to land.

I'm just hoping for a quick review for the new changes since patchset 1.

[bsalomon, 2016-06-30 18:47:46]

lgtm

[csmartdalton, 2016-06-30 18:48:23]

The CQ bit was checked by csmartdalton@google.com

[commit-bot: I haz the power, 2016-06-30 18:48:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:50:07]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[csmartdalton, 2016-06-30 18:57:59]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-06-30 18:57:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2066993003/#ps380001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-30 18:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 19:15:51]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
==========

[commit-bot: I haz the power, 2016-06-30 19:15:53]

Committed patchset #20 (id:380001) as
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

[commit-bot: I haz the power, 2016-06-30 19:15:56]

CQ bit was unchecked.

[Kunihiko Sakamoto, 2016-07-05 04:10:52]

A revert of this CL (patchset #20 id:380001) has been created in
https://codereview.chromium.org/2123693002/ by ksakamoto@chromium.org.

The reason for reverting is: This caused static initializer regressions in
Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7,
better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better
lower
.

[csmartdalton, 2016-07-05 18:21:36]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
==========

[csmartdalton, 2016-07-05 23:45:23]

csmartdalton@google.com changed reviewers:
+ ksakamoto@google.com

[csmartdalton, 2016-07-05 23:45:25]

This should remove the static initializer. Is there an easy way to re-run the
failing try bot from here?

[Kunihiko Sakamoto, 2016-07-06 01:21:16]

On 2016/07/05 23:45:25, csmartdalton wrote:
> This should remove the static initializer. Is there an easy way to re-run the
> failing try bot from here?

Not on trybots but you can run dump-static-initializers.py locally:
https://bugs.chromium.org/p/chromium/issues/detail?id=503622#c9

[csmartdalton, 2016-07-06 17:48:12]

On 2016/07/06 01:21:16, Kunihiko Sakamoto wrote:
> On 2016/07/05 23:45:25, csmartdalton wrote:
> > This should remove the static initializer. Is there an easy way to re-run
the
> > failing try bot from here?
> 
> Not on trybots but you can run dump-static-initializers.py locally:
> https://bugs.chromium.org/p/chromium/issues/detail?id=503622#c9

How does this work on mac? I get nothing when I do:

$ tools/mac/dump-static-initializers.py
out/Release/Chromium.app/Contents/MacOS/Chromium
<crickets>
$

[csmartdalton, 2016-07-07 07:53:29]

On 2016/07/06 17:48:12, csmartdalton wrote:
> On 2016/07/06 01:21:16, Kunihiko Sakamoto wrote:
> > On 2016/07/05 23:45:25, csmartdalton wrote:
> > > This should remove the static initializer. Is there an easy way to re-run
> the
> > > failing try bot from here?
> > 
> > Not on trybots but you can run dump-static-initializers.py locally:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=503622#c9
> 
> How does this work on mac? I get nothing when I do:
> 
> $ tools/mac/dump-static-initializers.py
> out/Release/Chromium.app/Contents/MacOS/Chromium
> <crickets>
> $

Nevermind I got it working on Linux. Verified the static initializer issue is
resolved.  can I get a sign off on the new changes in #22 and #23? 22 is the
static initializer fix in 23 is these three changes:

https://codereview.chromium.org/2120163002/
https://codereview.chromium.org/2119123002/
https://codereview.chromium.org/2115313002/

[bsalomon, 2016-07-07 13:51:38]

lgtm

[csmartdalton, 2016-07-07 15:27:04]

The CQ bit was checked by csmartdalton@google.com

[commit-bot: I haz the power, 2016-07-07 15:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 15:49:14]

Description was changed from

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
==========

to

==========
Begin instanced rendering for simple shapes

Adds a module that performs instanced rendering and starts using it
for a select subset of draws on Mac GL platforms. The instance
processor can currently handle rects, ovals, round rects, and double
round rects. It can generalize shapes as round rects in order to
improve batching. The instance processor also employs new drawing
algorithms, irrespective of instanced rendering, that improve GPU-side
performance (e.g. sample mask, different triangle layouts, etc.).

This change only scratches the surface of instanced rendering. The
majority of draws still only have one instance. Future work may
include:

 * Passing coord transforms through the texel buffer.
 * Sending FP uniforms through instanced vertex attribs.
 * Using instanced rendering for more draws (stencil writes,
   drawAtlas, etc.).
 * Adding more shapes to the instance processor’s repertoire.
 * Batching draws that have mismatched scissors (analyzing draw
   bounds, inserting clip planes, etc.).
 * Bindless textures.
 * Uber shaders.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003

Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891
Committed:
https://skia.googlesource.com/skia/+/a7f29640f6ab4eb50962a9d9f12d01ac2ce8b471
==========

[commit-bot: I haz the power, 2016-07-07 15:49:15]

Committed patchset #23 (id:440001) as
https://skia.googlesource.com/skia/+/a7f29640f6ab4eb50962a9d9f12d01ac2ce8b471