Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2060183003: Revert of Perform BSP polygon splitting and orientation selection in a single step. (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Perform BSP polygon splitting and orientation selection in a single step. (patchset #4 id:60001 of https://codereview.chromium.org/2043283002/ ) Reason for revert: Broke Windows 7 cc_unittests: DrawPolygonSplitTest.AngledSplit https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/53692 Original issue's description: > Perform BSP polygon splitting and orientation selection in a single step. > > This eliminates redundant testing of vertices for orientation with > respect to the splitting polygon. Previously, up to 3 sets of tests > were made (once to determine whether the polygon was split, then once > during the split, and then finally to determine the orientation of the > split polygons. > > Merging these steps in order to reuse calculated values also eliminates > the possibility that different calculations in testing and splitting > could be inconsistent. > > BUG=606984 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48 > Cr-Commit-Position: refs/heads/master@{#399459} TBR=enne@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606984 Committed: https://crrev.com/2d02c4132568ac72b26c7198ad112b19ba75cd95 Cr-Commit-Position: refs/heads/master@{#399472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -269 lines) Patch
M cc/output/bsp_tree.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/bsp_tree.cc View 2 chunks +43 lines, -16 lines 0 comments Download
M cc/output/bsp_tree_unittest.cc View 4 chunks +8 lines, -34 lines 0 comments Download
M cc/quads/draw_polygon.h View 1 chunk +7 lines, -4 lines 0 comments Download
M cc/quads/draw_polygon.cc View 3 chunks +185 lines, -146 lines 0 comments Download
M cc/quads/draw_polygon_unittest.cc View 9 chunks +38 lines, -66 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Fady Samuel
Created Revert of Perform BSP polygon splitting and orientation selection in a single step.
4 years, 6 months ago (2016-06-13 17:21:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060183003/1
4 years, 6 months ago (2016-06-13 17:22:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 17:23:28 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 17:23:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 17:24:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d02c4132568ac72b26c7198ad112b19ba75cd95
Cr-Commit-Position: refs/heads/master@{#399472}

Powered by Google App Engine
This is Rietveld 408576698