Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::current()->RunUntilIdle() in net. This CL replaces MessageLoop::current()->RunUntilIdle() with RunLoop().RunUntilIdle() in net. In files where this replacement is made, it adds this include: #include "base/run_loop.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why? - The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop but they will be able to use RunLoop. - MessageLoop::RunUntilIdle() is deprecated. Steps to generate this patch: 1. Run message_loop_cleanup_3.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=agl@chromium.org Committed: https://crrev.com/92e35a785e21e70b6ef69908561c3924c32c1146 Cr-Commit-Position: refs/heads/master@{#399197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -278 lines) Patch
M net/base/elements_upload_data_stream_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 10 chunks +18 lines, -18 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/disk_cache/disk_cache_perftest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M net/http/http_cache_unittest.cc View 39 chunks +42 lines, -42 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 23 chunks +27 lines, -27 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/proxy/proxy_script_decider_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M net/quic/bidirectional_stream_quic_impl_unittest.cc View 9 chunks +9 lines, -10 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/socket/socks_client_socket_pool_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 11 chunks +13 lines, -12 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 12 chunks +13 lines, -12 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/channel_id_service_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/ssl/default_channel_id_store_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M net/websockets/websocket_channel_test.cc View 25 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-10 12:28:35 UTC) #1
agl
lgtm
4 years, 6 months ago (2016-06-10 13:35:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053133002/1
4 years, 6 months ago (2016-06-10 15:49:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 15:55:07 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 15:57:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92e35a785e21e70b6ef69908561c3924c32c1146
Cr-Commit-Position: refs/heads/master@{#399197}

Powered by Google App Engine
This is Rietveld 408576698