Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: net/proxy/network_delegate_error_observer_unittest.cc

Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/network_delegate_error_observer_unittest.cc
diff --git a/net/proxy/network_delegate_error_observer_unittest.cc b/net/proxy/network_delegate_error_observer_unittest.cc
index 23037e9fad1fab36c31fef3486b7894a3223f565..51ea583874cb35583900e4f045f4327e7f0335df 100644
--- a/net/proxy/network_delegate_error_observer_unittest.cc
+++ b/net/proxy/network_delegate_error_observer_unittest.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/location.h"
+#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -91,7 +92,7 @@ TEST(NetworkDelegateErrorObserverTest, CallOnThread) {
FROM_HERE, base::Bind(&NetworkDelegateErrorObserver::OnPACScriptError,
base::Unretained(&observer), 42, base::string16()));
thread.Stop();
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
ASSERT_TRUE(network_delegate.got_pac_error());
}
@@ -105,7 +106,7 @@ TEST(NetworkDelegateErrorObserverTest, NoDelegate) {
FROM_HERE, base::Bind(&NetworkDelegateErrorObserver::OnPACScriptError,
base::Unretained(&observer), 42, base::string16()));
thread.Stop();
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
// Shouldn't have crashed until here...
}
« no previous file with comments | « net/proxy/multi_threaded_proxy_resolver_unittest.cc ('k') | net/proxy/proxy_config_service_linux_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698