net/proxy/proxy_script_decider_unittest.cc - Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_script_decider_unittest.cc

Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_script_decider_unittest.cc

diff --git a/net/proxy/proxy_script_decider_unittest.cc b/net/proxy/proxy_script_decider_unittest.cc

index f4eb33d23445bf4deb5c89649d55643978b8a7ed..94eb14ab0e0f33c1d47c400c7675c3cef14e0420 100644

--- a/net/proxy/proxy_script_decider_unittest.cc

+++ b/net/proxy/proxy_script_decider_unittest.cc

@@ -8,7 +8,6 @@

#include "base/location.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

-#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_util.h"

@@ -787,7 +786,7 @@ TEST(ProxyScriptDeciderTest, DhcpCancelledByDestructor) {

// back. Before the fix linked to above, this would try to invoke on

// the callback object provided by ProxyScriptDecider after it was

// no longer valid.

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

} // namespace

« no previous file with comments | « net/proxy/proxy_config_service_linux_unittest.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »