net/http/http_stream_factory_impl_request_unittest.cc - Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request_unittest.cc

Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_request_unittest.cc

diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc

index 06c9445170cefce394935fc4feef2753d9080231..5079cc1492e8266629432061d1c74a6091157c4f 100644

--- a/net/http/http_stream_factory_impl_request_unittest.cc

+++ b/net/http/http_stream_factory_impl_request_unittest.cc

@@ -6,6 +6,7 @@

#include <memory>

+#include "base/run_loop.h"

#include "net/http/http_stream_factory_impl_job.h"

#include "net/proxy/proxy_info.h"

#include "net/proxy/proxy_service.h"

@@ -156,7 +157,7 @@ TEST_P(HttpStreamFactoryImplRequestTest, DelayMainJob) {

job->Start(&request);

base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(wait_time + 1));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_NE(delay, job->wait_time_);

EXPECT_TRUE(job->wait_time_.is_zero());

« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc » ('j') | no next file with comments »