net/spdy/bidirectional_stream_spdy_impl_unittest.cc - Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/bidirectional_stream_spdy_impl_unittest.cc

Issue 2053133002: Remove MessageLoop::current()->RunUntilIdle() in net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/bidirectional_stream_spdy_impl_unittest.cc

diff --git a/net/spdy/bidirectional_stream_spdy_impl_unittest.cc b/net/spdy/bidirectional_stream_spdy_impl_unittest.cc

index 7e56cfee04c4e5c48b0759a5d5e27345f63ef9a6..5940e6257415db19a248c012fc5cef37d470951f 100644

--- a/net/spdy/bidirectional_stream_spdy_impl_unittest.cc

+++ b/net/spdy/bidirectional_stream_spdy_impl_unittest.cc

@@ -360,7 +360,7 @@ TEST_F(BidirectionalStreamSpdyImplTest, SendDataAfterCancelStream) {

// Try to send data after Cancel(), should not get called back.

delegate->SendData(buf.get(), buf->size(), false);

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_FALSE(delegate->on_failed_called());

EXPECT_EQ("200", delegate->response_headers().find(":status")->second);

« no previous file with comments | « net/socket/transport_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_http_stream_unittest.cc » ('j') | no next file with comments »