Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2052433003: [snapshot] make snapshot sink a non-dynamic member of the serializer. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@noref
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[snapshot] make snapshot sink a non-dynamic member of the serializer. R=vogelheim@chromium.org Committed: https://crrev.com/6f6f1f62ea8c06eb542c0442ef1013dca78aedfa Cr-Commit-Position: refs/heads/master@{#36890}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -76 lines) Patch
M src/api.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M src/snapshot/code-serializer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot/code-serializer.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M src/snapshot/partial-serializer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/snapshot/partial-serializer.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/snapshot/serializer.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/snapshot/serializer.cc View 9 chunks +26 lines, -27 lines 0 comments Download
M src/snapshot/startup-serializer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/startup-serializer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 4 chunks +7 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Yang
4 years, 6 months ago (2016-06-09 10:31:52 UTC) #1
vogelheim
lgtm
4 years, 6 months ago (2016-06-09 13:51:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052433003/40001
4 years, 6 months ago (2016-06-10 10:59:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 11:26:36 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:26:59 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f6f1f62ea8c06eb542c0442ef1013dca78aedfa
Cr-Commit-Position: refs/heads/master@{#36890}

Powered by Google App Engine
This is Rietveld 408576698