Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: src/api.cc

Issue 2052433003: [snapshot] make snapshot sink a non-dynamic member of the serializer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@noref
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/snapshot/code-serializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index a8cf0309fcd8faf4c1d70dd4dbde4e48871dd016..5bd6fa6c37378a01fa8b682838d415791e072c40 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -461,14 +461,10 @@ StartupData SnapshotCreator::CreateBlob(
}
data->contexts_.Clear();
- i::SnapshotByteSink snapshot_sink;
- i::StartupSerializer startup_serializer(isolate, &snapshot_sink,
- function_code_handling);
+ i::StartupSerializer startup_serializer(isolate, function_code_handling);
startup_serializer.SerializeStrongReferences();
- i::SnapshotByteSink context_sink;
- i::PartialSerializer context_serializer(isolate, &startup_serializer,
- &context_sink);
+ i::PartialSerializer context_serializer(isolate, &startup_serializer);
context_serializer.Serialize(&contexts[0]);
startup_serializer.SerializeWeakReferencesAndDeferred();
« no previous file with comments | « no previous file | src/snapshot/code-serializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698