[snapshot] support multiple contexts in the same snapshot.

[snapshot] support multiple contexts in the same snapshot.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
Committed: https://crrev.com/533453f9290b5668097f8db5362407f6e73a1d18
Cr-Commit-Position: refs/heads/master@{#37008}

[jochen (gone - plz use gerrit), 2016-06-13 15:24:20]

lgtm

https://codereview.chromium.org/2055203002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2055203002/diff/1/include/v8.h#newcode6797
include/v8.h:6797: int AddContext(Local<Context> context);
size_t?

[vogelheim, 2016-06-13 16:20:20]

lgtm

https://codereview.chromium.org/2055203002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2055203002/diff/1/include/v8.h#newcode7102
include/v8.h:7102: int context_snapshot_index = 0);
The argument context_snapshot_index has no \param section in the function
comment.

Should default be 0, or some invalid value (-1 or whatnot) for a non-snapshot
context?

https://codereview.chromium.org/2055203002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/2055203002/diff/1/test/cctest/test-serialize....
test/cctest/test-serialize.cc:1939: v8::Context::New(isolate, no_extension,
no_template, no_object, 2);
Hrmm.... so requesting context snapshot N+1 is the signal for getting a
snapshot-less context?

[Yang, 2016-06-14 11:45:30]

https://codereview.chromium.org/2055203002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2055203002/diff/1/include/v8.h#newcode6797
include/v8.h:6797: int AddContext(Local<Context> context);
On 2016/06/13 15:24:19, jochen (slow) wrote:
> size_t?

This is supposed to mirror the argument of Context::New, and just an index. So I
thought int would be fine.

https://codereview.chromium.org/2055203002/diff/1/include/v8.h#newcode7102
include/v8.h:7102: int context_snapshot_index = 0);
On 2016/06/13 16:20:20, vogelheim wrote:
> The argument context_snapshot_index has no \param section in the function
> comment.
> 
> Should default be 0, or some invalid value (-1 or whatnot) for a non-snapshot
> context?

0 as default reflects the current behavior. To create a context from scratch
(non-snapshot), you would have to set the default snapshot to null.

https://codereview.chromium.org/2055203002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/2055203002/diff/1/test/cctest/test-serialize....
test/cctest/test-serialize.cc:1939: v8::Context::New(isolate, no_extension,
no_template, no_object, 2);
On 2016/06/13 16:20:20, vogelheim wrote:
> Hrmm.... so requesting context snapshot N+1 is the signal for getting a
> snapshot-less context?

No... We added three contexts, so loading context #2 is fine. Loading out of
bound will lead to a CHECK failure.

[Yang, 2016-06-14 11:45:35]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 11:45:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/1

[commit-bot: I haz the power, 2016-06-14 11:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 11:48:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-06-14 11:59:42]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 11:59:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/20001

[commit-bot: I haz the power, 2016-06-14 12:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 12:17:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2016-06-14 13:06:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-14 13:06:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps40001
(title: "size_t and fix test")

[commit-bot: I haz the power, 2016-06-14 13:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/40001

[commit-bot: I haz the power, 2016-06-14 13:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:09:31]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7293)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3195)

[Yang, 2016-06-14 13:20:32]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-14 13:20:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps60001
(title: "fix printf")

[commit-bot: I haz the power, 2016-06-14 13:20:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/60001

[commit-bot: I haz the power, 2016-06-14 13:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:22:50]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7295)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-06-15 06:39:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 06:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps80001
(title: "turn everything into size_t")

[commit-bot: I haz the power, 2016-06-15 06:39:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/80001

[commit-bot: I haz the power, 2016-06-15 06:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 06:41:35]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7335)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-06-15 06:48:14]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 06:48:14]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps100001
(title: "fix build")

[commit-bot: I haz the power, 2016-06-15 06:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/100001

[commit-bot: I haz the power, 2016-06-15 07:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 07:17:36]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2016-06-15 08:11:20]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 08:11:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2016-06-15 08:11:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/120001

[commit-bot: I haz the power, 2016-06-15 08:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 08:59:36]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/8866)
  v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Yang, 2016-06-15 09:12:24]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-06-15 09:12:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/120001

[commit-bot: I haz the power, 2016-06-15 09:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 09:52:37]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/8874)
  v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Yang, 2016-06-15 10:56:44]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 10:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-15 10:56:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/140001

[commit-bot: I haz the power, 2016-06-15 11:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 11:48:49]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/8882)
  v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Yang, 2016-06-15 13:01:14]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 13:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps160001
(title: "another attempt")

[commit-bot: I haz the power, 2016-06-15 13:01:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/160001

[commit-bot: I haz the power, 2016-06-15 13:05:49]

Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-06-15 13:05:52]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 13:05:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps180001
(title: "size_t fix")

[commit-bot: I haz the power, 2016-06-15 13:05:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/180001

[commit-bot: I haz the power, 2016-06-15 13:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 13:41:02]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2016-06-15 15:08:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-15 15:08:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2055203002/#ps110014
(title: "fix test. again.")

[commit-bot: I haz the power, 2016-06-15 15:08:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055203002/110014

[commit-bot: I haz the power, 2016-06-15 15:38:49]

Committed patchset #11 (id:110014)

[commit-bot: I haz the power, 2016-06-15 15:39:14]

Description was changed from

==========
[snapshot] support multiple contexts in the same snapshot.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892
==========

to

==========
[snapshot] support multiple contexts in the same snapshot.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Committed: https://crrev.com/533453f9290b5668097f8db5362407f6e73a1d18
Cr-Commit-Position: refs/heads/master@{#37008}
==========

[commit-bot: I haz the power, 2016-06-15 15:39:16]

Patchset 11 (id:??) landed as
https://crrev.com/533453f9290b5668097f8db5362407f6e73a1d18
Cr-Commit-Position: refs/heads/master@{#37008}