[snapshot] pass arguments as pointers, not references.

[snapshot] pass arguments as pointers, not references.

R=vogelheim@chromium.org

Committed: https://crrev.com/75aada429e9e5aedb1b821f40fb56a4bca412740
Cr-Commit-Position: refs/heads/master@{#36887}

[vogelheim, 2016-06-09 13:46:10]

lgtm

https://codereview.chromium.org/2051043003/diff/1/src/snapshot/code-serializer.h
File src/snapshot/code-serializer.h (left):

https://codereview.chromium.org/2051043003/diff/1/src/snapshot/code-serialize...
src/snapshot/code-serializer.h:63: SerializedCodeData(const List<byte>& payload,
const CodeSerializer& cs);
Here & elsewhere: Why remove the const-ness?

(I'm not opposed; but I can't see any good reason, either.)

[Yang, 2016-06-10 05:33:28]

https://codereview.chromium.org/2051043003/diff/1/src/snapshot/code-serializer.h
File src/snapshot/code-serializer.h (left):

https://codereview.chromium.org/2051043003/diff/1/src/snapshot/code-serialize...
src/snapshot/code-serializer.h:63: SerializedCodeData(const List<byte>& payload,
const CodeSerializer& cs);
On 2016/06/09 13:46:10, vogelheim wrote:
> Here & elsewhere: Why remove the const-ness?
> 
> (I'm not opposed; but I can't see any good reason, either.)

Good point. I'll keep the constness around.

[Yang, 2016-06-10 05:44:57]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-10 05:44:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2051043003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-10 05:45:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051043003/20001

[commit-bot: I haz the power, 2016-06-10 05:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 05:46:17]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16921)

[Yang, 2016-06-10 10:31:25]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-10 10:31:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2051043003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-10 10:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051043003/40001

[commit-bot: I haz the power, 2016-06-10 10:58:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 10:59:08]

Description was changed from

==========
[snapshot] pass arguments as pointers, not references.

R=vogelheim@chromium.org
==========

to

==========
[snapshot] pass arguments as pointers, not references.

R=vogelheim@chromium.org

Committed: https://crrev.com/75aada429e9e5aedb1b821f40fb56a4bca412740
Cr-Commit-Position: refs/heads/master@{#36887}
==========

[commit-bot: I haz the power, 2016-06-10 10:59:09]

Patchset 3 (id:??) landed as
https://crrev.com/75aada429e9e5aedb1b821f40fb56a4bca412740
Cr-Commit-Position: refs/heads/master@{#36887}